Closed
Bug 85543
Opened 24 years ago
Closed 23 years ago
Extra blank box to the left of 'Done.' on mac classic skin.
Categories
(SeaMonkey :: Themes, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: stephend, Assigned: andreww)
References
Details
(Keywords: classic)
Attachments
(3 files)
(deleted),
patch
|
glazou
:
review+
asa
:
approval+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Build ID: 2001-06-12-08, Mac Classic
There exists an extra small box the size of the offline indicator,
which is to the left of the Done. status.
Note: On Mac Modern, there is a blank SPACE, but not a square. Whatever code is
causing this same bug.
Comment 4•23 years ago
|
||
r/sr=blake
Comment 5•23 years ago
|
||
Comment on attachment 48953 [details] [diff] [review]
begone
this rule is now empty and useless, just turn it into a comment; that removes the rule and helps resurrecting it just in case.
This bug is mac-classic specific and should be tested on a Mac.
r=glazman **providing the fact that it is visually tested on a Mac**.
Attachment #48953 -
Flags: review+
Comment 6•23 years ago
|
||
r=ksosezoff to bed now.
fix checked into trunk, requesting branch approval this is an eyesore and
verylow risk
Keywords: mozilla0.9.4
Comment 8•23 years ago
|
||
Comment on attachment 48953 [details] [diff] [review]
begone
low risk medium reward. a=asa for checkin to the 0.9.4 branch
Attachment #48953 -
Flags: approval+
thanks
Assignee: sspitzer → timeless
Component: Subscribe → Themes
Product: MailNews → Browser
Target Milestone: --- → mozilla0.9.4
Comment 10•23 years ago
|
||
fix checked into trunk and branch
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 11•23 years ago
|
||
/me wonders what is the point asking for reviews if you don't follow
them and ask for other reviews when the existing one are not matching
your desire.
Why did you keep the empty ruleset in (that was in my review) ?
Assignee | ||
Comment 12•23 years ago
|
||
yes the rule should have been removed as well. This is a leftover from
blake making a fix to windows classic skin and not (at the time) able to
access mac classic. The class selector should have been removed as
well.
Comment 13•23 years ago
|
||
I apologize for reviewing this hastily, I thought the entire rule was removed.
Comment 14•23 years ago
|
||
Comment 15•23 years ago
|
||
Comment 16•23 years ago
|
||
what's the point of complaining if you aren't going to listen to the response?
the patch itself needed to go in before 094 finalized, it did. i've attached a
cleanup patch which is designed for trunk only (since it benefits the branch so
insignificantly it would only add risk, and therefor fail any sane risk/benefit
analysis).
Comment 17•23 years ago
|
||
Changing the coding style in that file makes it inconsistent with the coding
style in all other files in that theme.
If you intend to make it consistent, please fix the unusual cases and not the
entire file.
that patch needs-work.
Comment 18•23 years ago
|
||
Ok, turns out some parts of mac-classic is written in one code style and some in
another.
Timeless, I suggest you just leave it alone (or create a new bug if you really
intend to "fix" it) - just make glazou's requested change (removing the unused
rule).
Reporter | ||
Comment 19•23 years ago
|
||
Re-opening, until the final patch has been through the reviewal and checkin process.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 21•23 years ago
|
||
.
Assignee: timeless → andreww
Severity: minor → trivial
Status: REOPENED → NEW
Target Milestone: mozilla0.9.5 → ---
Assignee | ||
Comment 22•23 years ago
|
||
the stuff that this patch would have fixed was already done in bug 97574.
Marking worksforme since it's already in .
Status: NEW → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → WORKSFORME
Updated•16 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•