Closed Bug 856629 Opened 12 years ago Closed 12 years ago

Implement ChildNode.remove()

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

Part a: Import test for select.remove
(deleted), patch
mounir
: review+
Details | Diff | Splinter Review
Part b: Implement ChildNode.remove()
(deleted), patch
bzbarsky
: review+
Details | Diff | Splinter Review
No description provided.
Did you mean Element.remove()? If not, could you link to the spec of ChildNode.remove, please, I'm curious :-)
<http://dom.spec.whatwg.org/#interface-childnode>. That is, Element/CharacterData/DocumentType.
Depends on: 841488, 851916
rs?
Attachment #734744 - Flags: review?(mounir)
Attachment #734746 - Flags: review?(mounir)
Comment on attachment 734744 [details] [diff] [review] Part a: Import test for select.remove Review of attachment 734744 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #734744 - Flags: review?(mounir) → review+
Comment on attachment 734746 [details] [diff] [review] Part b: Implement ChildNode.remove() I am at the SysApps F2F this week and I will have a hard time to dedicate time for this review. Hopefully Boris can do that before me. Otherwise, bounce this back to me.
Attachment #734746 - Flags: review?(mounir) → review?(bzbarsky)
Comment on attachment 734746 [details] [diff] [review] Part b: Implement ChildNode.remove() The right spec link is http://dom.spec.whatwg.org/#interface-childnode r=me with that, assuming you'll add the other form of remove() on <select> in bug 841488.
Attachment #734746 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky (:bz) from comment #7) > assuming you'll add the other form of remove() on <select> in bug 841488. I did, didn't I?
I didn't look at the patches; just assumed they contain the change.
https://hg.mozilla.org/mozilla-central/rev/942459e50bd0 https://hg.mozilla.org/mozilla-central/rev/9b71c6c95c6c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Depends on: 938799
Depends on: 1335150
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: