So, I have hit a fun problem. For select.options, the binding code does the following: nsRefPtr<mozilla::dom::HTMLOptionsCollection> result; result = self->Options(); if (!WrapNewBindingObject(cx, obj, result, vp)) { // ... WrapNewBindingObject gets a HTMLOptionsCollection* value, and calls value->GetWrapperPreserveColor(). The fun part is that HTMLOptionsCollection inherits from nsIHTMLCollection and nsWrapperCache, and both of these implement a GetWrapperPreserveColor... If someone has a way to make that compile, I'd love to hear about it.

Putting "using nsWrapperCache::GetWrapperPreserveColor;" on HTMLOptionsCollection ought to do it, I'd think.

There really is no point to having them both.

Comment on attachment 728994 [details] [diff] [review] Part a: Rename nsHTMLSelectElement Review of attachment 728994 [details] [diff] [review]: ----------------------------------------------------------------- I'm assuming you can run sed competently.

https://hg.mozilla.org/mozilla-central/rev/90213910e906 https://hg.mozilla.org/mozilla-central/rev/ae9ad697f8bc

Comment on attachment 728996 [details] [diff] [review] Part c: Implement the remainder of the WebIDL API Review of attachment 728996 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/html/content/src/HTMLSelectElement.cpp @@ +602,5 @@ > +{ > + nsGenericHTMLElement& element = > + aElement.IsHTMLOptionElement() ? > + static_cast<nsGenericHTMLElement&>(aElement.GetAsHTMLOptionElement()) : > + static_cast<nsGenericHTMLElement&>(aElement.GetAsHTMLOptGroupElement()); It would be nice if the codegen could provide a GetAsCommonBaseClass method for unions.

https://hg.mozilla.org/mozilla-central/rev/408f851aeb6b https://hg.mozilla.org/mozilla-central/rev/a809ae74995c