Closed
Bug 857034
Opened 12 years ago
Closed 12 years ago
Add support for native theming of <input type=range> on Windows
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
We need native theming of <input type=range> on Windows.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #732274 -
Flags: review?(roc)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 732274 [details] [diff] [review]
patch
>diff --git a/layout/forms/nsRangeFrame.cpp b/layout/forms/nsRangeFrame.cpp
>--- a/layout/forms/nsRangeFrame.cpp
>+++ b/layout/forms/nsRangeFrame.cpp
>@@ -126,17 +126,33 @@ nsRangeFrame::AppendAnonymousContentTo(n
> aElements.MaybeAppendElement(mThumbDiv);
> }
>
> void
> nsRangeFrame::BuildDisplayList(nsDisplayListBuilder* aBuilder,
> const nsRect& aDirtyRect,
> const nsDisplayListSet& aLists)
> {
>- BuildDisplayListForInline(aBuilder, aDirtyRect, aLists);
>+ DisplayBorderBackgroundOutline(aBuilder, aLists);
>+ if (IsThemed()) {
The DisplayBorderBackgroundOutline() call should be inside the |if| block, obviously. I've moved that locally.
Attachment #732274 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•