Closed Bug 859139 Opened 12 years ago Closed 12 years ago

Non native theming of input type range when specifying padding

Categories

(Core :: Widget: Win32, defect)

23 Branch
x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: daniel.nr01, Assigned: jwatt)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130406 Firefox/23.0 Build ID: 20130406030922 Steps to reproduce: See: http://jsbin.com/oqohel/1/ When padding is specified the slider loses its native styling. I'm using current Nightly on Windows 7 and without the padding I see a very nice Windows-like slider.
Blocks: 857034, 841950
Component: Untriaged → Widget: Win32
Product: Firefox → Core
This was intentional. The idea generally is that if you want to style the input, you don't want the native theming. For positioning purposes while keeping the native theming, it is possible to use the margin properties. If you specify border or padding, it will lose its theming.
Ah, I see. What about consistency with the behavior of inputs of type text/password/button? They only lose the native theming if you specify border. Padding might be used to increase click area and not only for positioning? Also e.g. Google Chrome keeps its native theming no matter what it seems.
Reasonable points. Mounir, what do you think?
(In reply to Jonathan Watt [:jwatt] from comment #3) > Reasonable points. Mounir, what do you think? Why can't we keep the native theming when there is a padding set?
Flags: needinfo?(jwatt)
We can. See comment 1. I was asking whether you thought that we should - I'll take that as a "yes".
Flags: needinfo?(jwatt)
Attached patch patch (deleted) — Splinter Review
Assignee: nobody → jwatt
Attachment #736222 - Flags: review?(mounir)
Comment on attachment 736222 [details] [diff] [review] patch Review of attachment 736222 [details] [diff] [review]: ----------------------------------------------------------------- r=me if the rendering is as expected. However, why not changing the other frames?
Attachment #736222 - Flags: review?(mounir) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b10100b29f19 (In reply to Mounir Lamouri (:mounir) from comment #7) > r=me if the rendering is as expected. However, why not changing the other > frames? The OX X native theming renders the entire range via one library call. It's not possible to adjust the position of the thumb of a natively themed range on that platform, so to keep things consistent that's what we do on all platforms.
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: