Closed Bug 860786 Opened 12 years ago Closed 12 years ago

Profile pages are slow to load with themes on them (part deux)

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED
2013-04-25

People

(Reporter: clouserw, Assigned: cvan)

References

Details

+++ This bug was initially created as a clone of Bug #860407 +++ We migrated a zillion themes to AMO, yay. However, our user profiles pages are not handling scaling well. An example of a user with 1300 themes takes about 20s to load: https://addons.mozilla.org/en-US/firefox/user/sassygirl1016/ When Madonna's themes finish up syncing (10000+) it's going to crush us. In bug 860407 ashort put a LIMIT 60 on the query so we don't explode the servers. This bug is about: 1) backing out https://github.com/mozilla/zamboni/commit/3f2f1f7464564ee5ef571c026540487c51862970 2) Fix this bug the right way, so it'll be a list of all the themes the designer has done, and fast enough that it'll scale.
Summary: Profile pages are slow to load with themes on them → Profile pages are slow to load with themes on them (part deux)
We use amo.utils.paginate for addons, but not personas. Is that because paginate can only be used once per page?
Assignee: nobody → cvan
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2013-04-18
$ time curl -silent -o /dev/null https://addons-dev.allizom.org/en-US/firefox/user/clouserw/ real 0m12.784s user 0m0.032s sys 0m0.036s We gotta do better than 12 seconds, and that's a profile with 10% of the themes that madonna has.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Locally I got us from 685 queries http://f.cl.ly/items/29472P063o2t2t440U04/Screen%20Shot%202013-04-11%20at%207.36.22%20PM.png down to 78 queries http://f.cl.ly/items/1G1v2b350v0i0O2a172C/Screen%20Shot%202013-04-11%20at%207.44.22%20PM.png Now the big issue here is the lack of pagination for browsing themes - we're displaying all of the themes on the page, then using the hovercard grid to simulate pagination (using CSS). I would opt for creating another paginator on the page, but we can't (easily) do that with the "Add-ons I've Created" section also on the page. I'll either need to create a separate ?page_addons vs. ?page_themes counts. Or, we could force the user to toggle between Add-ons vs. Themes. Or we could use AJAX to do a kind of fragment loading for Themes. I'm opting for the latter, but it's not a trivial change here.
Query optimisations: https://github.com/mozilla/zamboni/commit/5b8abd7 Pagination to come later, sooner than later.
Put the Top 60 back (this time it's actually the 60 most popular): https://github.com/mozilla/zamboni/commit/6797c4a We should try to do AJAX pagination and show them per page. But this should suffice for now.
Just talked to cvan about how to handle View All. Best thing to do might be to have a View All link beside the dot nav that takes you to a separate page. This page would be based on the Most Popular page template. This page's UX handles a large number of themes well and also has sorting options, which is great for people who like to follow designers with a large catalog.
Status: REOPENED → ASSIGNED
https://github.com/mozilla/zamboni/commit/1c31fe9 We list the theme artist's top 40 themes ... https://addons-dev.allizom.org/en-US/firefox/user/MaDonna ... and a link to "View all" ... https://addons-dev.allizom.org/en-US/firefox/user/MaDonna/themes Let me know if there's anything else.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Target Milestone: 2013-04-18 → 2013-04-25
Sorry if I'm nit-picking on grammar, but can we change "My most popular 20 Themes" to "My Most Popular Themes"? Or if we want to keep a number in there, then perhaps "My Top 20 Themes". I'm fine with either one.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Verified as fixed in https://marketplace-dev.allizom.org/ on FF20 (Win 7). Postfix screencast http://screencast.com/t/GZHBvmxafFh Closing bug.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.