Data reporting policy will be notified through Android system notifications (pull-down notification bar). Behavior is "tap to choose what is shared" and "dismiss to accept policy."

I assume we can easily distinguish between systems which allow richer notifications (IIRC 4.1 and up) and older platforms? If so I think we want to take advantage of more descriptive strings where possible.

Fennec ships with the backwards compatibility library for older versions, and that should make it very straightforward to support both old and new style system notifications.

Ian, any update on strings for the Android system notification of data policy? Currently, the notification placeholders are [title] "&brandShortName metrics reporting" and [summary] "Tap to choose what to send".

Hi there, sorry for the delay on this. Attached is a mockup showing how we can handle this message on newer devices that support expandable notifications, and also on older ones where only a title and second line is permitted. ** Strings for Android 4.2+ ** [title] &brandShortName stats & data [summary] To improve your experience, &brandShortName automatically sends some information to Mozilla. [action] Choose what information to share ** Strings for Android 4.1 and earlier ** [title] &brandShortName stats & data [action] Choose what information to share

Ian, do we want a shorter/different string if it might get cut off on some devices? Or do we not care? (This is a Motorola DroidX running 2.3.4 on Verizon) On this particular device, the string could be "show" or "share" or perhaps even something else; it's not entirely clear.

Could use “Choose what to share”, or “Choose what to share with Mozilla” (which seems more friendly for those users who can see it).

Added screenshot using big notifications - it looks a little different because I wasn't able to find the right icons (grey gear vs white gear, black-background Firefox logo vs aqua-background). If you can provide me the icons, that'd be fantastic, or I can just file a followup to update them.

(In reply to Chenxia Liu [:liuche] from comment #5) > Created attachment 747701 [details] > Screenshot: Motorola 2.3 notification truncation > > Ian, do we want a shorter/different string if it might get cut off on some > devices? Or do we not care? (This is a Motorola DroidX running 2.3.4 on > Verizon) > > On this particular device, the string could be "show" or "share" or perhaps > even something else; it's not entirely clear. Perhaps it could just read "Choose what to share" in cases like this where we have space constraints. I would still like to keep the word "information" wherever we can on devices where we have room though

(In reply to Chenxia Liu [:liuche] from comment #7) > Created attachment 747757 [details] > Screenshot: Big notifications view > > Added screenshot using big notifications - it looks a little different > because I wasn't able to find the right icons (grey gear vs white gear, > black-background Firefox logo vs aqua-background). > > If you can provide me the icons, that'd be fantastic, or I can just file a > followup to update them. Here are the white gear icons :) http://cl.ly/2y1k1i1J0a3F

Thanks Ian! Trying to land this for 23, and it looks like checking notification space is fairly difficult (and may just involve extrapolating from screen size, etc). I will file a follow-up for it and investigate further to see if there is a better way to estimate space, though I can't make any promises. :\

Per discussion this morning with ibarlow and mfinkle, changed crashreporter settings string to be less "Firefox-y", removed two-state-slider in data choices, and added notification ticker.

Comment on attachment 749049 [details] [diff] [review] Part 1: Ticker text + checkboxes Review of attachment 749049 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. ::: mobile/android/base/DataReportingNotification.java @@ +81,2 @@ > Notification notification = new NotificationCompat.Builder(context) > + .setTicker(tickerText) the nittiest of nits: it seems like the ticker is less important than everything else, so should go below the title. I know, that's an OCD level nit :) ::: mobile/android/base/locales/en-US/android_strings.dtd @@ +151,4 @@ > <!ENTITY datareporting_telemetry_summary "Shares performance, usage, hardware and customization data about your browser with &vendorShortName; to help us make &brandShortName; better"> > <!ENTITY datareporting_crashreporter_summary "&brandShortName; submits crash reports to help &vendorShortName; make your browser more stable and secure"> > <!-- Localization note (datareporting_crashreporter_title) : This string matches > + (crashReporterSection.label) in en-US/chrome/browser/preferences/advanced.dtd.--> why en-US? Oh, because this is locales/en-US/android_strings.dtd. ::: mobile/android/base/strings.xml.in @@ +135,4 @@ > > <string name="datareporting_notification_title">&datareporting_notification_title;</string> > <string name="datareporting_notification_action">&datareporting_notification_action;</string> > + <string name="datareporting_notification_action_short">&datareporting_notification_action_short;</string> Are the old strings still used? If not, I think we generally use blah2 to indicate deprecation.

Thanks, Nick! All the strings are still actually used, and the ticker text is actually a concatenation of two previous strings (containing one word that had been dropped due to truncation on an Android version I tested on).

This patch should have not landed as it is (unless I'm misreading the diff) -<!ENTITY datareporting_crashreporter_title "&brandShortName; Crash Reporter"> +<!ENTITY datareporting_crashreporter_title2 "&brandShortName; Crash Reporter"> +<!ENTITY datareporting_crashreporter_title "Crash Reporter"> This way you changed datareporting_crashreporter_title to a different value without changing its ID (you can't do that), while you could have just done something like this +<!ENTITY datareporting_crashreporter_titleShort "Crash Reporter"> Is it possible to fix or backout this before it moves into mozilla-central?

Chenxia: this is in 24, right? Target milestone!