As explained in Bug 862116 Comment 15 -<!ENTITY datareporting_crashreporter_title "&brandShortName; Crash Reporter"> +<!ENTITY datareporting_crashreporter_title2 "&brandShortName; Crash Reporter"> +<!ENTITY datareporting_crashreporter_title "Crash Reporter"> Unfortunately this already landed in mozilla-central, so a name change for datareporting_crashreporter_title is needed at this point. About string changes after landing https://developer.mozilla.org/en-US/docs/Making_String_Changes

> About string changes after landing > https://developer.mozilla.org/en-US/docs/Making_String_Changes Thanks for the documentation link, flod.

Sorry for the localization problem, Francesco. I've uploaded a patch to rename the old crashreporter entity to its originally landed name and update the new string. If I'm wrong about what you meant by renaming, please correct me!

Forgot to fix in strings.

It's too late for that approach: once a string lands on mozilla-central, if you want to change its content you need to change its ID too. That's the only way to ensure that localizers see the change and don't use outdated strings as a reference. Now on mozilla-central there are these two strings <!ENTITY datareporting_crashreporter_title2 "&brandShortName; Crash Reporter"> <!ENTITY datareporting_crashreporter_title "Crash Reporter"> datareporting_crashreporter_title has been changed from the original value in bug 862116, so it has to be renamed. But now you want to change both strings, so you need new IDs for both. My suggestion would to add strings like these <!ENTITY datareporting_crashreporter_titleLong "&brandShortName; Crash Reporter"> <!ENTITY datareporting_crashreporter_titleShort "Crash Reporter">

Renamed both strings, and updated references up the chain.

Comment on attachment 749382 [details] [diff] [review] Part 1: Rename old crashreporter entity to previous property name v3 Review of attachment 749382 [details] [diff] [review]: ----------------------------------------------------------------- We don't use camelCase in entities/strings. Please change that to an _underscore. Rest looks fine.

Sorry, didn't know that. Patch looks good, but looking at the code I have a doubt: is the string datareporting_crashreporter_title2 (now to be changed in datareporting_crashreporter_title_long) used somewhere?

No, this is basically a complete string replace - we no longer want to use the old crashreporter string. Should I remove it completely if it's no longer going to be used?

If it's not used anymore absolutely yes. Bug 862116 comment 13 made me think that it was still used somewhere.

Updated to remove camelCase and removed old crashreporter string completely.