Closed
Bug 862197
Opened 12 years ago
Closed 12 years ago
ttlview.js pref observer's use of bind() makes no sense
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: etienne)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
alive
:
review+
|
Details | Diff | Splinter Review |
The code is:
78 SettingsListener.observe('debug.ttl.enabled', false, function(value) {
79 !!value ? TTLView.show().bind(TTLView) : TTLView.hide().bind(TTLView);
80 });
but both TTLView.show and TTLView.hide return undefined, so this just throws when called, after doing the show or hide.
This is causing test failures for me once I make us actually report the exception correctly instead of silently disappearing it into the ether, since then marionette sees the exception and does it's usual "panic, abort" thing.
For what it's worth, I can't figure out what those bind() calls are trying to accomplish, exactly...
Flags: needinfo?(alive)
|
Assignee | |
Comment 1•12 years ago
|
||
Looks like a change done while debugging that slipped through.
Assignee: nobody → etienne
Attachment #737954 -
Flags: review?(alive)
|
||
Updated•12 years ago
|
Attachment #737954 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 3•12 years ago
|
||
Thanks for the quick turnaround on this!
Do I need to file a separate bug to get the emulator the infrastructure uses updated with this, or is there a planned update in the not too far future?
Flags: needinfo?(alive) → needinfo?(jgriffin)
|
||
Comment 4•12 years ago
|
||
Yes, we need another bug for the emulator update. I'll take care of it.
Flags: needinfo?(jgriffin)
|
|
Reporter | |
Comment 5•12 years ago
|
||
Thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•