Boris Zbarsky [:bzbarsky] Reporter
	Description • 11 years ago

The code is:

78 SettingsListener.observe('debug.ttl.enabled', false, function(value) {
79   !!value ? TTLView.show().bind(TTLView) : TTLView.hide().bind(TTLView);
80 });

but both TTLView.show and TTLView.hide return undefined, so this just throws when called, after doing the show or hide.

This is causing test failures for me once I make us actually report the exception correctly instead of silently disappearing it into the ether, since then marionette sees the exception and does it's usual "panic, abort" thing.

For what it's worth, I can't figure out what those bind() calls are trying to accomplish, exactly...

	Etienne Segonzac (:etienne) Assignee
	Comment 1 • 11 years ago

Looks like a change done while debugging that slipped through.

	Etienne Segonzac (:etienne) Assignee
	Comment 2 • 11 years ago

https://github.com/mozilla-b2g/gaia/commit/86bf941140bbbd8769ba9045329e47213948870e

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 3 • 11 years ago

Thanks for the quick turnaround on this!

Do I need to file a separate bug to get the emulator the infrastructure uses updated with this, or is there a planned update in the not too far future?

	Jonathan Griffin (:jgriffin)
	Comment 4 • 11 years ago

Yes, we need another bug for the emulator update.  I'll take care of it.

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 5 • 11 years ago

Thanks!