Closed Bug 862306 Opened 12 years ago Closed 12 years ago

Route audio stream to BT_SCO in AudioManager

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
firefox21 --- wontfix
firefox22 --- wontfix
firefox23 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: gyeh, Assigned: rlin)

References

Details

(Whiteboard: [fixed-in-birch])

Attachments

(3 files)

Route audio stream to BT_SCO in AudioManager
(deleted), patch
mwu
: review+
Details | Diff | Splinter Review
check in patch
(deleted), patch
Details | Diff | Splinter Review
Bug 862306 - Route audio stream to BT_SCO in AudioManager. r=mwu, a=tef+
(deleted), patch
Details | Diff | Splinter Review
Per Randy in https://bugzilla.mozilla.org/show_bug.cgi?id=859727#12, we'd like to route audio stream after bt_sco is established/broken in AudioManager.
Blocks: 859727
Nominated as leo? since it blocks bug 859727(leo+).
blocking-b2g: --- → leo?
We want to remove the patch switch logic on bluetooth, so we decide to move the setforceuse from bluetooch to audioManager.
Attachment #737970 - Flags: review?(fabrice)
Assignee: nobody → rlin
Attachment #737970 - Flags: review?(fabrice) → review?(mchen)
Comment on attachment 737970 [details] [diff] [review] Route audio stream to BT_SCO in AudioManager Hi Randy, I have no right to review code in this file so transfer to Michael Wu. Hi Michanel, Could you help to review this patch?
Attachment #737970 - Flags: review?(mchen) → review?(mwu)
blocking-b2g: leo? → leo+
Comment on attachment 737970 [details] [diff] [review] Route audio stream to BT_SCO in AudioManager Review of attachment 737970 [details] [diff] [review]: ----------------------------------------------------------------- Code looks right but I don't understand one comment. ::: dom/system/gonk/AudioManager.cpp @@ +154,4 @@ > AUDIO_POLICY_DEVICE_STATE_AVAILABLE, address); > AudioSystem::setDeviceConnectionState(AUDIO_DEVICE_IN_BLUETOOTH_SCO_HEADSET, > AUDIO_POLICY_DEVICE_STATE_AVAILABLE, address); > + // Phase in the a2dp profile, this should be called when phone call is established. Can you rephrase this? I don't understand what this means.
Attachment #737970 - Flags: review?(mwu) → review+
Attached patch check in patch (deleted) — — Splinter Review
remove the comment, It's just remonder we should have another change when a2dp feature is enabled.
this patch should apply with the bug 859727 at the same time.
Whiteboard: checkin-needed
Thanks, Randy. I'll land it with bug 859727 to birch.
Whiteboard: checkin-needed → checkin-needed [fixed-in-birch]
Whiteboard: checkin-needed [fixed-in-birch] → [fixed-in-birch]
https://hg.mozilla.org/mozilla-central/rev/9c118c313eda
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Blocks: 872428
This patch is required by bug 872428, which is tef+, so I'm requesting tef+ here so we can uplift this.
blocking-b2g: leo+ → tef?
blocks a blocker
blocking-b2g: tef? → tef+
Whiteboard: [fixed-in-birch] → [status: needs uplift][fixed-in-birch]
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/430b0d1ce2cc
status-b2g18-v1.0.1: affected → fixed
Whiteboard: [status: needs uplift][fixed-in-birch] → [fixed-in-birch]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: