Closed Bug 872428 Opened 11 years ago Closed 11 years ago

[Bluetooth][Certification]Audio path does not route to Bluetooth SCO

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

Product:
Firefox OS Graveyard
Component:
Bluetooth
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(blocking-b2g:tef+, firefox22 wontfix, firefox23 wontfix, firefox24 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: shawnjohnjr, Assigned: shawnjohnjr)

References

Details

(Whiteboard: [target:5/15][fixed-in-birch] QARegressExclude)

Attachments

(3 files, 3 obsolete files)

b2g18-v101:Bug 872428 - Fix missing setForceUse to BT SCO for audio path, r=mwu, a=tef+
(deleted), patch
Details | Diff | Splinter Review
b2g18:Bug 872428 - Fix missing setForceUse to BT SCO for audio path, r=mwu, a=tef+
(deleted), patch
Details | Diff | Splinter Review
central:Bug 872428 - Fix missing setForceUse to BT SCO for audio path, r=mwu, a=tef+
(deleted), patch
Details | Diff | Splinter Review
While testing AG_ACS, we found audio path does not output to correct path in v1.0.1. After patch of Bug 830213 applied, the code of audio path shall also be changed.
Severity: normal → blocker
Whiteboard: [status:needs patch][target:5/15]
blocking-b2g: --- → tef?
Attached patch Patch1:V1 for b2g18-v101 (obsolete) (deleted) — — Splinter Review
This is must have patch, otherwise BT SCO audio path get screw up.
Attachment #749738 - Flags: review?(rlin)
Attachment #749738 - Flags: review?(mwu)
Whiteboard: [status:needs patch][target:5/15] → [status:needs review][target:5/15]
Comment on attachment 749738 [details] [diff] [review] Patch1:V1 for b2g18-v101 Review of attachment 749738 [details] [diff] [review]: ----------------------------------------------------------------- The patch looks to me. But needs mwu to give r+.
Attachment #749738 - Flags: review?(rlin)
Attached patch Patch1:V1 for central, (obsolete) (deleted) — — Splinter Review
Attachment #749749 - Flags: review?(mwu)
Attached patch Patch1:V1 for b2g18 (obsolete) (deleted) — — Splinter Review
b2g18 version
For central, b2g18 patch, if aData is empty Bluetooth address, it shall do setForce to None. Without this, it can also cause serious audio path missing problem.
blocking-b2g: tef? → tef+
I've tested the following scenarios: Scenario A: 1. Connected BT headset, during call session, turn off BT headset 2. Check audio path correctly switch back to earpiece Scenario B: 1. Connected BT headset, during call session, switch to speaker, turn off BT headset 2. Check audio path correctly switch back to speaker 3. Switch to earpieces again and check audio path routed to earpieces Scenario C: 1. Turn off Bt headset, make a phone call, during the call session, turn on BT headset 2. Check audio path correctly switch back to BT headset 3. Switch to speaker again check path to speaker
blocking-b2g: tef+ → tef?
Sorry, update comment but touch blocking-b2g:tef+.
tef+ again.
blocking-b2g: tef? → tef+
Comment on attachment 749749 [details] [diff] [review] Patch1:V1 for central, Review of attachment 749749 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/AudioManager.cpp @@ +144,5 @@ > const char* aTopic, > const PRUnichar* aData) > { > if (!strcmp(aTopic, BLUETOOTH_SCO_STATUS_CHANGED)) { > + if (NS_strlen(aData) > 0) { Testing for *aData would be the fastest way, though perhaps not the most obvious.
Attachment #749749 - Flags: review?(mwu) → review+
Depends on: 862306
Comment on attachment 749738 [details] [diff] [review] Patch1:V1 for b2g18-v101 This looks identical to the m-c patch + bug 862306. I'm going to request tef+ for bug 862306 so you can uplift that.
Attachment #749738 - Flags: review?(mwu)
Whiteboard: [status:needs review][target:5/15] → [status:needs landing][target:5/15]
Attachment #749749 - Attachment description: Patch1:V1 for central → Patch1:V1 for central,
Attachment #750247 - Attachment description: Bug 872428 - Fix missing setForceUse to BT SCO for audio path, r=mwu, a=tef+ → b2g18-v101:Bug 872428 - Fix missing setForceUse to BT SCO for audio path, r=mwu, a=tef+
Note: b2g18v101 patch depend on bug 862306. So bug 862306 needs to uplift first.
birch: https://hg.mozilla.org/projects/birch/rev/1e5c4b1cd4c4
Whiteboard: [status:needs landing][target:5/15] → [status:needs landing][target:5/15][fixed-in-birch]
(In reply to Shawn Huang from comment #14) > Note: b2g18v101 patch depend on bug 862306. So bug 862306 needs to uplift > first. bug 862306 has been landed.
Hello Ryan, can you help to uplift?
Flags: needinfo?(ryanvm)
(In reply to Shawn Huang from comment #17) > Hello Ryan, can you help to uplift? As usual, once birch is merged to m-c next, I'll take care of the uplift, yes.
Flags: needinfo?(ryanvm)
https://hg.mozilla.org/mozilla-central/rev/1e5c4b1cd4c4
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g18: --- → affected
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → affected
status-firefox22: --- → wontfix
status-firefox23: --- → wontfix
status-firefox24: --- → fixed
Resolution: --- → FIXED
Whiteboard: [status:needs landing][target:5/15][fixed-in-birch] → [status:needs uplift][target:5/15][fixed-in-birch]
Unable to verify. Lack of resources. Need Bluetooth PTS tool to verify. Marking as QARegressExclude.
Whiteboard: [target:5/15][fixed-in-birch] → [target:5/15][fixed-in-birch] QARegressExclude
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: