Closed
Bug 862629
Opened 11 years ago
Closed 11 years ago
Stop wrapping WebIDL callbacks into the compartment of the thing we're passing them to
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(2 files)
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
This is causing failures with WebIDL event listeners, because if we addEventListener via an Xray we end up wrapping it into the content compartment, and then we can't get it's .handleEvent. I talked to Kyle and Bobby and they both think we should just stop doing this wrapping altogether rather than special-casing Xrays somehow.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #738298 -
Flags: review?(peterv)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #738299 -
Flags: review?(peterv)
Assignee | ||
Updated•11 years ago
|
Whiteboard: [need review]
Comment 3•11 years ago
|
||
Comment on attachment 738298 [details] [diff] [review] part 1. Stop playing compartment games with WebIDL callbacks and just use the given object as-is. Review of attachment 738298 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bindings/CallbackFunction.h @@ +30,2 @@ > { > + MOZ_ASSERT(JS_ObjectIsCallable(nullptr, aCallable)); Want to file a bug on removing the cx argument or adding a friend api that doesn't need one?
Attachment #738298 -
Flags: review?(peterv) → review+
Updated•11 years ago
|
Attachment #738299 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 4•11 years ago
|
||
> Want to file a bug on removing the cx argument Filed bug 865399.
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9129688d03de https://hg.mozilla.org/integration/mozilla-inbound/rev/170c15712591
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla23
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9129688d03de https://hg.mozilla.org/mozilla-central/rev/170c15712591
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•