Andrew McCreight [:mccr8] Reporter
	Description • 11 years ago

"Comment 4 sounds like a bug in our js-implemented codegen for dictionaries: dictionary arguments are const structs, but dictionary return values can't be const because of the ToObject thing.  That said, I wonder why ToObject is not a const method... we should consider fixing that if we can."

	Andrew McCreight [:mccr8] Reporter
	Comment 3 • 11 years ago

Comment on attachment 739910 [details] [diff] [review]
Add support for dictionary arguments in JS-implemented WebIDL bindings.

Review of attachment 739910 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/test/TestJSImplGen.webidl
@@ -327,5 @@
>    void passOptionalNullableObjectWithDefaultValue(optional object? arg = null);
>    object receiveObject();
>    object? receiveNullableObject();
>  
> -/* The rest of these are untested.

Thanks for looking at these and filing bugs!

	Andrew McCreight [:mccr8] Reporter
	Comment 4 • 11 years ago

FYI, I included this patch in my try run, and it was all green.
  https://tbpl.mozilla.org/?tree=Try&rev=7ddb2c175154

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 5 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/4f09599d049f

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/4f09599d049f