Closed
Bug 865778
Opened 12 years ago
Closed 11 years ago
stop making assumptions about mozconfig names in release sanity
Categories
(Release Engineering :: Release Automation: Other, defect)
Tracking
(firefox23+ fixed)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(1 file)
(deleted),
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
bug 853071 is going to change the in-tree mozconfigs a bit. After it's done we'll have mozconfigs that are used for releases that end in "beta". Release sanity makes some assumptions about mozconfig naming that will become invalid when this is done:
https://github.com/mozilla/build-tools/blob/master/lib/python/release/sanity.py#L83
https://github.com/mozilla/build-tools/blob/master/lib/python/release/sanity.py#L89
We should either fix this to strip the last part of the path regardless of what it is, or be explicit about which mozconfig we should compare against by putting them in the release config. Maybe something like:
releaseConfig['mozconfigs'] = {
'linux': {
'nightly': '...',
'release': '...'
}
}
Assignee | ||
Comment 1•11 years ago
|
||
We need this bug to support bug 853071 in release automation. 23.0b1 will be the first release with that code.
tracking-firefox23:
--- → ?
Assignee | ||
Comment 2•11 years ago
|
||
Turns out that we can look up the nightly mozconfigs in the branchConfig rather than duplicating that information to the release ones. I tested this locally by rerunning release sanity for 22.0b3.
Updated•11 years ago
|
Attachment #757474 -
Flags: review?(rail) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 757474 [details] [diff] [review]
get rid of assumptions
I'm on the hook for the beta this week, so this is a good time to get the first production run!
Attachment #757474 -
Flags: checked-in+
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Updated•11 years ago
|
status-firefox23:
--- → fixed
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•