Comment on attachment 743081 [details] [diff] [review] part 1 - renaming Review of attachment 743081 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/svg/content/src/nsDOMSVGZoomEvent.h @@ +8,1 @@ > mozilla_dom_SVGZoomEvent_h

Comment on attachment 743082 [details] [diff] [review] part 2 - webidl Review of attachment 743082 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/svg/content/src/SVGZoomEvent.cpp @@ -84,2 @@ > NS_INTERFACE_MAP_END_INHERITING(nsDOMUIEvent) > Don't declare nsISupports since you're not overriding anything. ::: content/svg/content/src/SVGZoomEvent.h @@ +19,3 @@ > namespace dom { > > +class SVGZoomEvent : public nsDOMUIEvent MOZ_FINAL ::: dom/bindings/Bindings.conf @@ +989,5 @@ > > +'SVGZoomEvent': { > + 'nativeType': 'mozilla::dom::SVGZoomEvent' > +}, > + Don't need this

Comment on attachment 743150 [details] [diff] [review] part 1 - renaming Review of attachment 743150 [details] [diff] [review]: ----------------------------------------------------------------- r=me with those comments. ::: content/svg/content/src/nsDOMSVGZoomEvent.cpp @@ +17,5 @@ > > //---------------------------------------------------------------------- > // Implementation > > +SVGZoomEvent::SVGZoomEvent(mozilla::dom::EventTarget* aOwner, Drop the mozilla::dom ::: content/svg/content/src/nsDOMSVGZoomEvent.h @@ +23,3 @@ > { > public: > typedef mozilla::DOMSVGPoint DOMSVGPoint; Don't need this anymore

Comment on attachment 743151 [details] [diff] [review] part 2 - webidl Review of attachment 743151 [details] [diff] [review]: ----------------------------------------------------------------- r=me with those comments. ::: content/svg/content/src/SVGZoomEvent.h @@ +13,4 @@ > > class nsGUIEvent; > class nsPresContext; > +class nsISVGPoint; Sort @@ +24,5 @@ > typedef mozilla::DOMSVGPoint DOMSVGPoint; > > SVGZoomEvent(EventTarget* aOwner, nsPresContext* aPresContext, > nsGUIEvent* aEvent); > Fix the trailing whitespace while you're here @@ +31,5 @@ > > + virtual JSObject* WrapObject(JSContext* aCx, > + JS::Handle<JSObject*> aScope) MOZ_OVERRIDE > + { > + return mozilla::dom::SVGZoomEventBinding::Wrap(aCx, aScope, this); Drop the mozilla::dom:: ::: dom/interfaces/svg/moz.build @@ +15,5 @@ > 'nsIDOMSVGDocument.idl', > 'nsIDOMSVGElement.idl', > 'nsIDOMSVGLength.idl', > 'nsIDOMSVGNumber.idl', > + 'nsIDOMSVGRect.idl' Keep the trailing comma ::: dom/webidl/SVGZoomEvent.webidl @@ +16,5 @@ > + > + readonly attribute float previousScale; > + readonly attribute SVGPoint previousTranslate; > + readonly attribute float newScale; > + readonly attribute SVGPoint newTranslate; Make the two points nullable. And all these should be [Constant].

https://hg.mozilla.org/integration/mozilla-inbound/rev/38997ae06dc6 https://hg.mozilla.org/integration/mozilla-inbound/rev/750587157bc3

https://hg.mozilla.org/mozilla-central/rev/38997ae06dc6 https://hg.mozilla.org/mozilla-central/rev/750587157bc3