Closed
Bug 868778
Opened 11 years ago
Closed 11 years ago
Move DataChannel to WebIDL
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
VERIFIED
FIXED
mozilla24
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
(Whiteboard: [WebRTC][blocking-webrtc-])
Attachments
(3 files)
(deleted),
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mounir
:
review+
jesup
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Updated•11 years ago
|
Whiteboard: [WebRTC][blocking-webrtc-]
Assignee | ||
Comment 1•11 years ago
|
||
I want that file name...
Attachment #747993 -
Flags: review?(rjesup)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #747994 -
Flags: review?(rjesup)
Assignee | ||
Comment 3•11 years ago
|
||
I removed the XPIDL send() because it was too much work to keep it; left the rest of the XPIDL interface because people seemed to QI to it, at least.
Attachment #747995 -
Flags: review?(mounir)
Updated•11 years ago
|
Attachment #747993 -
Flags: review?(rjesup) → review+
Updated•11 years ago
|
Attachment #747994 -
Flags: review?(rjesup) → review+
Comment 4•11 years ago
|
||
Comment on attachment 747995 [details] [diff] [review] Part c: Move to WebIDL Review of attachment 747995 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me but I would feel more comfortable to get someone who knows that code to check this patch too. ::: content/base/src/nsDOMDataChannel.cpp @@ +56,5 @@ > mDataChannel->SetListener(nullptr, nullptr); > mDataChannel->Close(); > } > > + nit: no need to add this blank line ::: content/base/src/nsDOMDataChannel.h @@ +7,5 @@ > #ifndef nsDOMDataChannel_h > #define nsDOMDataChannel_h > > +#include "mozilla/dom/DataChannelBinding.h" > +#include "mozilla/dom/TypedArray.h" It's not obvious why you need those #include. Could you double-check that they are actually needed?
Attachment #747995 -
Flags: review?(rjesup)
Attachment #747995 -
Flags: review?(mounir)
Attachment #747995 -
Flags: review+
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Mounir Lamouri (:mounir) from comment #4) > Comment on attachment 747995 [details] [diff] [review] > Part c: Move to WebIDL > > Review of attachment 747995 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good to me but I would feel more comfortable to get someone who knows > that code to check this patch too. > > ::: content/base/src/nsDOMDataChannel.cpp > @@ +56,5 @@ > > mDataChannel->SetListener(nullptr, nullptr); > > mDataChannel->Close(); > > } > > > > + > > nit: no need to add this blank line > > ::: content/base/src/nsDOMDataChannel.h > @@ +7,5 @@ > > #ifndef nsDOMDataChannel_h > > #define nsDOMDataChannel_h > > > > +#include "mozilla/dom/DataChannelBinding.h" > > +#include "mozilla/dom/TypedArray.h" > > It's not obvious why you need those #include. Could you double-check that > they are actually needed? You can't forward declare enums (for DataChannelBinding.h) or typedefs (for TypedArray.h).
Updated•11 years ago
|
Attachment #747995 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7197c7cc8a30 https://hg.mozilla.org/mozilla-central/rev/60c386548d5e https://hg.mozilla.org/mozilla-central/rev/b94e996b05fd And because I forgot SetIsDOMBinding() and we apparently don't have any tests for send(): https://hg.mozilla.org/mozilla-central/rev/ca7f8131a8d4
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Comment 7•11 years ago
|
||
Did a good amount of regression testing on this today with my test app for doing remote data channel communication - lgtm on nightly.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in
before you can comment on or make changes to this bug.
Description
•