Mike Pennisi [:jugglinmike] Assignee
	Description • 11 years ago

The latest MMS UI specification includes an "attach" button that allows the user to attach media of any type. Currently, the `pick` MozActivity does not support selecting generic media. Extend the `pick` activity once the MozActivity API supports it.

	Mike Pennisi [:jugglinmike] Assignee
	Comment 1 • 11 years ago

As discussed in Bug 870157, the `pick` MozActivity does indeed support multiple media types. The API for requesting multiple types is specification of an array of type strings, e.g.:

```
new MozActivity({
  name: 'pick',
  data: {
    type: ['image/*', 'video/*', 'audio/*']
  }
})
```

	Corey Frang [:gnarf]
	Comment 2 • 11 years ago

We also need to add "maxFileSize" to the data for this activity to support the video capture clause in bug 868225 - see bug 878042

	Corey Frang [:gnarf]
	Comment 3 • 11 years ago

We should also try to tackle the "file too big" scenarios in this patch

	Mike Pennisi [:jugglinmike] Assignee
	Comment 5 • 11 years ago

I've created Bug 880813 to track the changes surrounding maximum file size that Corey requested in comment 2 and comment 3.

	Corey Frang [:gnarf]
	Comment 6 • 11 years ago

Comment on attachment 759899 [details] [diff] [review]
Implement attachment of generic media

Review of attachment 759899 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.

We know there are some problems here, but most of them are not gaia's fault.

After a short discussion with Dietrich about this in IRC, we have decided to land this and get it on train ASAP so that QA and the gecko team can both test with these attachment types enabled.

	Mike Pennisi [:jugglinmike] Assignee
	Comment 7 • 11 years ago

Landed at commit fbbd63bee46225a1bc6ea7a62daa296802825863

By enabling audio and video, Corey and I identified two issues that we believe to be at the Gecko layer:

- Bug 880825 - [MMS] Unable to Open audio and video immediately after attaching
- Bug 880828 - [MMS] Sending audio and video attachments fails

Thanks for the review, Corey!

	John Ford [:jhford] CET/CEST Berlin Time
	Comment 8 • 11 years ago

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x  fbbd63bee46225a1bc6ea7a62daa296802825863
  <RESOLVE MERGE CONFLICTS>
  git commit

	Corey Frang [:gnarf]
	Comment 9 • 11 years ago

Uplifted fbbd63bee46225a1bc6ea7a62daa296802825863 to:
v1-train: 928c27e714f447b468fbd05e8f7b76024cc8648e

	Mike Pennisi [:jugglinmike] Assignee
	Comment 10 • 11 years ago

Thanks for resolving the conflict, Corey!