Closed
Bug 871978
Opened 11 years ago
Closed 11 years ago
Incorrect usage of SwitchPreference in pre-v14 Android
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox23+ verified, firefox24 unaffected)
VERIFIED
FIXED
Firefox 23
Tracking | Status | |
---|---|---|
firefox23 | + | verified |
firefox24 | --- | unaffected |
People
(Reporter: TeoVermesan, Assigned: liuche)
References
Details
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
sriram
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Tested with:
Build: Firefox for Android 23.0a1(2013-05-14)
Device: Acer Iconia A500
OS: Android 3.2.1
Steps to reproduce:
1. Open Firefox
2. Go to Settings > Privacy&Security > Data Choices
Actual results:
- A blank page is displayed
Expected results:
- The following settings should appear
*Telemetry
*Nightly Health Report
*Nightly Crash Reporter
Note: Going to home screen, a pop-up appears "Activity Nightly(in application Nightly) is not responding"
Updated•11 years ago
|
Assignee: nobody → liuche
Updated•11 years ago
|
status-firefox23:
--- → affected
status-firefox24:
--- → affected
Reporter | ||
Comment 2•11 years ago
|
||
Flags: needinfo?(teodora.vermesan)
Comment 3•11 years ago
|
||
Can you attach a log-cat when you try and access data options?
Comment 5•11 years ago
|
||
Looks like http://developer.android.com/reference/android/preference/SwitchPreference.html was introduced in API Level 14; we need some compatibility with lower API levels.
Comment 6•11 years ago
|
||
We do have a fallback. It just only applies if we aren't using fragments. Honeycomb is the red headed stepchild here.
Assignee | ||
Comment 7•11 years ago
|
||
Ah, I see what's happening. There's an xml file with SwitchPreference that should be in xml-14, but is actually in xml-11.
24 is actually not affected, because after talking with ibarlow yesterday morning, we decided to remove the SwitchPreference, so bug 862116 fixes that.
I prepare a patch for Aurora that removes xml-v11 as well.
Assignee | ||
Updated•11 years ago
|
Summary: Page displayed blank when going to Settings > Privacy&Security > Data Choices on Honeycomb → Incorrect usage of SwitchPreference in pre-v14 Android
Assignee | ||
Comment 8•11 years ago
|
||
Running an aurora build currently, will request review when tested.
Assignee | ||
Comment 9•11 years ago
|
||
Hi Teodora, can you try this build on your device, to see if the problem still exists in this build? It will install as a Nightly app, not an Aurora one.
http://people.mozilla.com/~liuche/bug-871978/no-switch-nightly.apk
Alternatively, can QA check that this fixes the bug on an Android device of the same version as the reporters? This should be any device between v11 and v13, inclusive.
Flags: needinfo?(teodora.vermesan)
Assignee | ||
Comment 10•11 years ago
|
||
Sorry, I meant this will install as an Aurora app instead of a Nightly one.
Reporter | ||
Comment 11•11 years ago
|
||
(In reply to Chenxia Liu [:liuche] from comment #9)
> Hi Teodora, can you try this build on your device, to see if the problem
> still exists in this build? It will install as a Nightly app, not an Aurora
> one.
>
> http://people.mozilla.com/~liuche/bug-871978/no-switch-nightly.apk
I cannot reproduce the issue on the given build. Please let me know if I can help furthermore.
Flags: needinfo?(teodora.vermesan)
Assignee | ||
Comment 12•11 years ago
|
||
Comment on attachment 749414 [details] [diff] [review]
Part 1: Remove SwitchPreference xml preference screen v1
This patch removes the SwitchPreference usage from the preferences xml, as discussed with ibarlow. I will flag for uplift to Aurora after review.
Attachment #749414 -
Flags: review?(sriram)
Comment 13•11 years ago
|
||
Comment on attachment 749414 [details] [diff] [review]
Part 1: Remove SwitchPreference xml preference screen v1
Review of attachment 749414 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #749414 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 14•11 years ago
|
||
Comment on attachment 749414 [details] [diff] [review]
Part 1: Remove SwitchPreference xml preference screen v1
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 833625
User impact if declined: Users of Android v11-v13 will see an "activity not responding" when navigating to control telemetry/FHR/crashreporter upload settings.
Testing completed (on m-c, etc.): softvisio testing of attached Aurora patch; patch is currently live in Nightly 24 (bug 862116).
Risk to taking this patch (and alternatives if risky): Low, only code removal, no new behavior.
String or IDL/UUID changes made by this patch: none
Attachment #749414 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #749414 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•11 years ago
|
tracking-firefox23:
--- → +
Assignee | ||
Comment 15•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Updated•11 years ago
|
Comment 16•11 years ago
|
||
Landing on trunk?
Assignee | ||
Comment 17•11 years ago
|
||
This only affected Fx23 - bug 862116 independently landed on trunk earlier and resolved this on Fx24 (see comment 7).
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 18•11 years ago
|
||
Teodora, can you verify this on Aurora with your Honeycomb tablet?
Flags: needinfo?(teodora.vermesan)
Keywords: verifyme
Updated•11 years ago
|
Target Milestone: --- → Firefox 23
Reporter | ||
Comment 19•11 years ago
|
||
The Data Choices setting page is not blank anymore. It is displayed correctly on Firefox for Android 23.0a2(2013-05-28) on Acer Iconia A500 (Android 3.2.1)
Flags: needinfo?(teodora.vermesan)
Comment 20•11 years ago
|
||
Marking bug as verified based on comment 19.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•