Closed Bug 873703 Opened 12 years ago Closed 12 years ago

[SMS][MMS] correct l10n pluralizations

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed

People

(Reporter: rwaldron, Assigned: kaze)

References

Details

(Whiteboard: u=fx-os-user c=scravag-sprint p=1)

Attachments

(1 file, 1 obsolete file)

link to pull request — l10n fix
(deleted), text/html
rwaldron
: review+
julienw
: review+
Details
Address any issues with l10n pluralizations
leo? because this affects languages with several plural forms, like polish, and poland is one target country. This is a left over from Bug 868679.
blocking-b2g: --- → leo?
NI dietrich pour leo+
Flags: needinfo?(dietrich)
Attached image page 12 (obsolete) (deleted) —
Sorry, I attached this to the wrong bug :(
Attachment #751704 - Attachment is obsolete: true
This is a regression caused by bug 868679.
Blocks: 873477
Kaze "volunteered" to fix this today.
Assignee: felash → kaze
Blocks: 874441
Attached file link to pull request — l10n fix (deleted) —
Attachment #752412 - Flags: review?(felash)
Attachment #752412 - Flags: feedback?(waldron.rick)
Attachment #752412 - Flags: feedback?(waldron.rick) → review?(waldron.rick)
Whiteboard: u=fx-os-user c=scravag-sprint-may-20-31 p=1
Whiteboard: u=fx-os-user c=scravag-sprint-may-20-31 p=1 → u=fx-os-user c=scravag-sprint p=1
Blocks: 872039
Comment on attachment 752412 [details] link to pull request — l10n fix looks good -> feedback+ waiting for unit tests for l10n.js to r+. Note that we don't reproduce the display "... and others" with the current master.
Attachment #752412 - Flags: review?(felash) → feedback+
Unit tests added for l10n.js. (In reply to Julien Wajsberg [:julienw] from comment #8) > Note that we don't reproduce the display "... and others" with the current > master. I confirm: I had to force the value of `others' directly in the code to test that.
Comment on attachment 752412 [details] link to pull request — l10n fix r=me thanks for the tests !
Attachment #752412 - Flags: feedback+ → review+
Attachment #752412 - Flags: review?(waldron.rick) → review+
Merged on master: https://github.com/mozilla-b2g/gaia/commit/c200a7d49c17f549895b39d8f0cd138835fbe37f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
blocking-b2g: leo? → leo+
Flags: needinfo?(dietrich)
Whiteboard: u=fx-os-user c=scravag-sprint p=1 → u=fx-os-user c=scravag-sprint p=1 [NO_UPLIFT]
Whiteboard: u=fx-os-user c=scravag-sprint p=1 [NO_UPLIFT] → u=fx-os-user c=scravag-sprint p=1
v1-train: e792dfb
status-b2g18: --- → fixed
Depends on: 913360
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: