Closed
Bug 913360
Opened 11 years ago
Closed 11 years ago
Hard-coded en-US plural in threads with multiple recipients
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:leo+, firefox26 unaffected, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)
People
(Reporter: stas, Assigned: julienw)
References
Details
(Whiteboard: [u=commsapps-user c=messaging p=0.5 s=v1.1-bugs-sprint-20130902])
Attachments
(1 file)
https://github.com/mozilla-b2g/gaia/blob/2529db165272ac53bfcb3b426be884e4e86dde89/apps/sms/js/thread_ui.js#L262
var message = count ?
(count > 1 ? 'recipient[many]' : 'recipient[one]') :
'newMessage';
this.headerText.textContent = navigator.mozL10n.get(message, {
n: count
});
Instead, you should simply do:
var message = count ? 'recipient' : 'newMessage';
this.headerText.textContent = navigator.mozL10n.get(message, {
n: count
});
mozL10n will take care of the plural form with the benefit of doing it right for languages where plurals are more complex (.e.g use different plural form for 2, 3 and 4). Assuming it's more common to send text messages to just a few recipients (when sending to more than one), this bug might be very visible in these languages.
This affects v1-train only.
|
Reporter | |
Updated•11 years ago
|
blocking-b2g: --- → leo?
|
Assignee | |
Comment 1•11 years ago
|
||
Right, we somehow missed this in Bug 873703, but eventually did it in non--leo+ bug 886715 (with a lot of other changes).
Bug 873703 was leo+ so it's probably a good idea to have this leo+ too.
Stas, as it seems like you already did the change, could you do a pull request and ask review from me ?
Assignee: nobody → stas
Blocks: 873703
|
|
Assignee | |
Comment 2•11 years ago
|
||
Bug 906753 changed it actually, but it builded on top of bug 886715.
It looks like we can just remove all this code and call this.updateComposerHeader(), as we did in master. I'll do a chirurgical patch.
Assignee: stas → felash
|
|
Assignee | |
Comment 3•11 years ago
|
||
Chirurgical patch to fix this l10n issue on v1.1.
_don't merge if we don't get leo+_
Attachment #800694 -
Flags: review?(fbsc)
|
|
Assignee | |
Updated•11 years ago
|
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=messaging p=0.5 s=v1.1-bugs-sprint-20130902]
|
||
Comment 4•11 years ago
|
||
Tony,
Please have Delphine test it to make sure we get the plural translation right.
Flags: needinfo?(tchung)
|
||
Comment 5•11 years ago
|
||
Julien, small comment in the bug and we are ready for merging! :)
|
|
Assignee | |
Comment 6•11 years ago
|
||
updated the PR with your comment :)
still not leo+ so don't merge !
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 800694 [details]
913360-pull-request.txt
R+. Merge when this will be leo+!
Attachment #800694 -
Flags: review?(fbsc) → review+
|
|
Assignee | |
Updated•11 years ago
|
Flags: needinfo?(jcheng)
|
|
||
Comment 9•11 years ago
|
||
QA,
Please test the plurals.
leo+
blocking-b2g: leo? → leo+
Keywords: qawanted
|
||
Updated•11 years ago
|
QA Contact: mdavydova
|
||
Updated•11 years ago
|
Flags: needinfo?(jcheng)
|
||
Comment 10•11 years ago
|
||
(In reply to Preeti Raghunath(:Preeti) from comment #9)
> QA,
>
> Please test the plurals.
>
> leo+
This isn't really a case to qawanted here - we'll verify the bug if we get to it. It's not a high risk change either.
Keywords: qawanted
|
|
Assignee | |
Comment 11•11 years ago
|
||
v1-train: 5f7ea0c3f9290dae2db1274472af343cb61890fa
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-b2g-v1.1hd:
--- → affected
status-firefox26:
--- → unaffected
Flags: needinfo?(felash)
Resolution: --- → FIXED
|
||
Comment 12•11 years ago
|
||
v1.1.0hd: 5f7ea0c3f9290dae2db1274472af343cb61890fa
v1.1.0hd: d8a50a044d0bea1d91462d2a3cc38fb9c367b2b5
|
||
Comment 13•11 years ago
|
||
not QA actionable, clearing flag.
|
|
||
Updated•11 years ago
|
Flags: needinfo?(tchung)
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•