Closed
Bug 874521
Opened 12 years ago
Closed 7 years ago
Move r2d2b2g SimluatorScreen.js code to Gaia/tools/extensions/desktop-helper
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: vingtetun, Unassigned)
References
Details
That would let Gaia devs use it inside the b2g-desktop/the browser directly.
Gaia part:
https://github.com/vingtetun/gaia/commit/c1deef52f892cefc0149501ba6370e719e7b3ccc
r2d2b2g part:
https://github.com/vingtetun/r2d2b2g/commit/f294b055d32633c49e2aea7fe3b591c8398d9e44
The main change I did is that I made a small tweak in order to ignore a specificity of the system app when it runs inside Firefox (it runs inside a <browser> tag and not directly inside a <iframe mozbrowser>. This is a bug I would fix later.
Also I have added some parameters to the observers.
If you guys (Myk and Alexandre) feels ok with it who is the best reviewer for both patches?
Flags: needinfo?(poirot.alex)
Flags: needinfo?(myk)
Comment 1•12 years ago
|
||
I'm fine with it as long as we can continue to land fixes/enhancements for the Simulator into the Gaia version of the module. And r=myk on the r2d2b2g changes, which are straightforward. But @ochameau should review the Gaia changes, as I'm not a Gaia reviewer.
Flags: needinfo?(myk)
Reporter | ||
Comment 2•12 years ago
|
||
(In reply to Myk Melez [:myk] [@mykmelez] from comment #1)
> I'm fine with it as long as we can continue to land fixes/enhancements for
> the Simulator into the Gaia version of the module. And r=myk on the r2d2b2g
> changes, which are straightforward. But @ochameau should review the Gaia
> changes, as I'm not a Gaia reviewer.
Obviously. I'm fine to give you permission to land code on Gaia and to make you a reviewer of the tools/extensions part as well.
Also landing on v1-train should be straigforward since all this directory is NPTOB. so a=NPTOB for all changes there (still need a review though).
Thanks for the good will here. Very much appreciated.
Comment 3•12 years ago
|
||
I'm ready to review gaia patch.
It would be cool to execute this in two steps to ease the review:
- make desktop helper non-boostrapped addon,
- integrate simulator screen code.
Flags: needinfo?(poirot.alex)
Comment 4•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•