:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Description • 11 years ago

I'm not sure how Navigator::Invalidate() works exactly, do I dunno if the MozTimeManager -> MozTimeManager wrapper -> Window wrapper -> Window -> Navigator -> MozTimeManager is broken correctly.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 1 • 11 years ago

Comment on attachment 753797 [details] [diff] [review]
Patch v1

update uuid of nsIDOMMozNavigatorTime

	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 2 • 11 years ago

test_time.html now fails because it relies on having an XPIDL interface. See <https://tbpl.mozilla.org/php/getParsedLog.php?id=23651757&tree=Try>. Can you deal with that?

	David Chan [:dchan]
	Comment 3 • 11 years ago

(In reply to :Ms2ger from comment #2)
> test_time.html now fails because it relies on having an XPIDL interface. See
> <https://tbpl.mozilla.org/php/getParsedLog.php?id=23651757&tree=Try>. Can
> you deal with that?

I'll apply your patch and work on a fix for the permissions tests. I think I need to perform a QI to get the correct type and check that.

	David Chan [:dchan]
	Comment 4 • 11 years ago

I tested the patch in bug 878814 with your changes and it works. test_time.html will need a slight change from
 23     idl: "nsIDOMMozTimeManager",
to
 23     webidl: "MozTimeManager",

	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 5 • 11 years ago

Thanks!

	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 6 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/4eba1004b5eb