Closed Bug 877025 Opened 11 years ago Closed 11 years ago

Touch-based video controls show "firstShow" state when the video is already playing

Categories

(Toolkit :: Video/Audio Controls, defect)

Product:
Toolkit
Component:
Video/Audio Controls
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla24
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- fixed
b2g18 --- verified
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(1 file)

fix
(deleted), patch
Dolske
: review+
fabrice
: approval-mozilla-b2g18+
Details | Diff | Splinter Review
In the B2G Youtube app, pressing "play" on the video plays the video, but the first time you tap on the video after it's playing we show the "firstShow" controls (a single button which should be "play", but is actually "pause").
Attached patch fix (deleted) — — Splinter Review
This patch is a no-brainer I think.
Attachment #755138 - Flags: review?(dolske)
Attachment #755138 - Flags: review?(jaws)
Attachment #755138 - Flags: review?(dolske)
Attachment #755138 - Flags: review+
Comment on attachment 755138 [details] [diff] [review] fix NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): none User impact if declined: in Youtube app, video controls shown for the first time on an already-playing video will only show a "pause" button Testing completed: a very small amount of manual testing Risk to taking this patch (and alternatives if risky): very very low risk. It just limits the one-button controls UI to fewer cases (i.e. excludes the case where the video is already playing). String or UUID changes made by this patch: none
Attachment #755138 - Flags: approval-mozilla-b2g18?
Attachment #755138 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
blocking-b2g: --- → tef?
Haven't been able to uplift this yet due to tree closures.
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/36a5c31cd7e2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
blocking-b2g: tef? → tef+
Keywords: verifyme
QA Contact: jsmith
Note - this might have caused bug 877025. Going to confirm.
(In reply to Jason Smith [:jsmith] from comment #7) > Note - this might have caused bug 877025. Going to confirm. Meant to say - bug 878060.
Works fine on b2g18 on a 5/31 build.
status-b2g18: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: