Closed
Bug 877320
Opened 11 years ago
Closed 11 years ago
Expose a node front in the Selection object in addition to a raw node
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: dcamp, Assigned: dcamp)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #758237 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Attachment #764484 -
Attachment description: WIP 2 → v1
Attachment #764484 -
Flags: review?(paul)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 764484 [details] [diff] [review]
v1
>diff --git a/browser/devtools/fontinspector/font-inspector.js b/browser/devtools/fontinspector/font-inspector.js
>--- a/browser/devtools/fontinspector/font-inspector.js
>+++ b/browser/devtools/fontinspector/font-inspector.js
>@@ -49,16 +49,17 @@ FontInspector.prototype = {
> }
> },
>
> /**
> * Selection 'new-node' event handler.
> */
> onNewNode: function FI_onNewNode() {
> if (this.isActive() &&
>+ this.inspector.selection.isLocal() &&
> this.inspector.selection.isConnected() &&
> this.inspector.selection.isElementNode() &&
> this.inspector.selection.reason != "highlighter") {
> this.undim();
> this.update();
> } else {
> this.dim();
> }
I'm not sure to understand why you do that here?
Do you check `isLocal` to disable the font inspector in case of remote inspection?
Attachment #764484 -
Flags: review?(paul) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Assignee: nobody → dcamp
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•