Closed Bug 881120 Opened 11 years ago Closed 11 years ago

Allow clients to specify nodes that shouldn't be released

Categories

(DevTools :: Inspector, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 24

People

(Reporter: dcamp, Assigned: dcamp)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch v1 (obsolete) (deleted) — Splinter Review
Clients need to be able to specify interest in a remote node, so that it isn't cleaned up during normal cleanup routines. Specifically, we need this for markup view's Undo feature when deleting, that keeps around a reference to a detached node in case of undo.
The debugger's threadGrip request does something similar (promote pause-scoped grips to thread-scoped ones). We should probably generalize the concept and harmonize the implementations at some point.
Attached patch v2 (deleted) — Splinter Review
Hopefully this is the last of the tree-fiddling patches.
Attachment #760258 - Attachment is obsolete: true
Attachment #761282 - Flags: review?(jwalker)
Depends on: 878443
Attachment #761282 - Flags: review?(jwalker) → review+
Attached patch Factor out mutation queuing (deleted) — Splinter Review
v2 depends on this small patch
Attachment #763190 - Flags: review?(jwalker)
Attachment #763190 - Flags: review?(paul)
Blocks: 877320
Attachment #763190 - Flags: review?(jwalker) → review+
Attachment #763190 - Flags: review?(paul) → review+
Paul - I think dcamp gave us both reviews because either of us could review this, not because both of us should review it. So I think you can skip this.
Timing!
Assignee: nobody → dcamp
Whiteboard: [fixed-in-fx-team]
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: