Closed
Bug 881082
Opened 11 years ago
Closed 11 years ago
Rename metro-immersive to mochitest-metro-chrome and add it to the trychooser page and debug jobs
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jimm, Assigned: armenzg)
References
Details
Attachments
(5 files, 1 obsolete file)
(deleted),
patch
|
philor
:
review+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
coop
:
review+
jimm
:
feedback+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
coop
:
review+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
armenzg
:
review+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mbrubeck
:
review+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
We recently enabled metro mochitests on try, inbound, and mc. However when you push a patch to try with '-u mochitests', these tests don't run. Instead you have to run all tests which is a waste of resources.
I'd like to request metro mochitests be included with mochitest test try runs.
-u mochitests
https://tbpl.mozilla.org/?tree=Try&showall=1&rev=a361e7b8bc26
-u all
https://tbpl.mozilla.org/?tree=Try&showall=1&rev=94a861c12278
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → armenzg
Assignee | ||
Comment 1•11 years ago
|
||
If you use showall=1 you should be able to see it:
https://tbpl.mozilla.org/?tree=Try&showall=1&rev=94a861c12278
I think you should also be able to get it with this:
try: -b o -p win32 -u metro-immersive -t none
You would need to use showall=1 as well.
Does this work for you?
Flags: needinfo?(jmathies)
Reporter | ||
Comment 2•11 years ago
|
||
(In reply to Armen Zambrano G. [:armenzg] (Release Enginerring) from comment #1)
> If you use showall=1 you should be able to see it:
> https://tbpl.mozilla.org/?tree=Try&showall=1&rev=94a861c12278
That's a '-u all' run. With a '-u mochitest' run, it doesn't trigger:
https://tbpl.mozilla.org/?tree=Try&showall=1&rev=a361e7b8bc26
> I think you should also be able to get it with this:
> try: -b o -p win32 -u metro-immersive -t none
Haven't tried that but will, if it works it will be handy to have.
Flags: needinfo?(jmathies)
Comment 3•11 years ago
|
||
Yeah, I would have said that the core of this bug was two things, "add metro-immersive to trychooser" and "add metro-immersive to http://mxr.mozilla.org/build/source/buildbotcustom/try_parser.py#16"
But, if it actually is mochitest-metro, why is it named metro-immersive?
Assignee | ||
Comment 4•11 years ago
|
||
Assignee | ||
Comment 5•11 years ago
|
||
jimm, according to what philor says, should we name the job "mochitest-metro"? would that be more appropriate?
Reporter | ||
Comment 6•11 years ago
|
||
(In reply to Armen Zambrano G. [:armenzg] (Release Enginerring) from comment #5)
> jimm, according to what philor says, should we name the job
> "mochitest-metro"? would that be more appropriate?
How about mochitest-browser-chrome to match desktop?
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #6)
> (In reply to Armen Zambrano G. [:armenzg] (Release Enginerring) from comment
> #5)
> > jimm, according to what philor says, should we name the job
> > "mochitest-metro"? would that be more appropriate?
>
> How about mochitest-browser-chrome to match desktop?
We already have that named being used. We can't use the same name... I think.
Reporter | ||
Comment 8•11 years ago
|
||
(In reply to Armen Zambrano G. [:armenzg] (Release Enginerring) from comment #7)
> (In reply to Jim Mathies [:jimm] from comment #6)
> > (In reply to Armen Zambrano G. [:armenzg] (Release Enginerring) from comment
> > #5)
> > > jimm, according to what philor says, should we name the job
> > > "mochitest-metro"? would that be more appropriate?
> >
> > How about mochitest-browser-chrome to match desktop?
>
> We already have that named being used. We can't use the same name... I think.
Doh, I meant mochitest-metro-chrome! :)
Assignee | ||
Updated•11 years ago
|
Summary: Add mochitest-metro-chrome to mochitests try runs → Rename metro-immersive to mochitest-metro-chrome and add it to the trychooser page
Assignee | ||
Comment 9•11 years ago
|
||
Attachment #761191 -
Attachment is obsolete: true
Assignee | ||
Comment 10•11 years ago
|
||
Assignee | ||
Comment 11•11 years ago
|
||
Assignee | ||
Comment 12•11 years ago
|
||
Comment on attachment 761493 [details] [diff] [review]
[mozharness] rename metro jobs
jimm, we would still be calling it with --browser --metro-immersive, correct?
Attachment #761493 -
Flags: feedback?(jmathies)
Assignee | ||
Updated•11 years ago
|
Reporter | ||
Comment 13•11 years ago
|
||
(In reply to Armen Zambrano G. [:armenzg] (Release Enginerring) from comment #12)
> Comment on attachment 761493 [details] [diff] [review]
> [mozharness] rename metro jobs
>
> jimm, we would still be calling it with --browser --metro-immersive, correct?
Right. The metro-immersive monicker is a little misleading I know. At one point we had support for running these on the desktop, which would have been metro-desktop, but we took that out a while back. 'metro-immersive' stuck around.
Reporter | ||
Updated•11 years ago
|
Attachment #761493 -
Flags: feedback?(jmathies) → feedback+
Assignee | ||
Updated•11 years ago
|
Attachment #761492 -
Flags: review?(philringnalda)
Assignee | ||
Updated•11 years ago
|
Attachment #761493 -
Flags: review?(coop)
Assignee | ||
Updated•11 years ago
|
Attachment #761494 -
Flags: review?(coop)
Assignee | ||
Comment 14•11 years ago
|
||
This is working on staging.
Comment 15•11 years ago
|
||
Comment on attachment 761492 [details] [diff] [review]
[trychooser] add metro jobs
lgtm - I tried to come up with some reason for the "mochitest-o" thing to exist, and thus a reason why this ought to be mochitest-mc, but I couldn't come up with anything other than "maybe we used to have narrow columns."
Attachment #761492 -
Flags: review?(philringnalda) → review+
Assignee | ||
Comment 16•11 years ago
|
||
Comment on attachment 761492 [details] [diff] [review]
[trychooser] add metro jobs
https://hg.mozilla.org/build/tools/rev/db1d47944f57
Attachment #761492 -
Flags: checked-in+
Updated•11 years ago
|
Attachment #761493 -
Flags: review?(coop) → review+
Updated•11 years ago
|
Attachment #761494 -
Flags: review?(coop) → review+
Assignee | ||
Updated•11 years ago
|
Attachment #761493 -
Flags: checked-in+
Assignee | ||
Updated•11 years ago
|
Attachment #761494 -
Flags: checked-in+
Assignee | ||
Comment 17•11 years ago
|
||
r=coop
Attachment #762033 -
Flags: review+
Attachment #762033 -
Flags: checked-in+
Reporter | ||
Comment 18•11 years ago
|
||
please let us know when this goes live so we can swap out the new try server directive we've been using.
Assignee | ||
Comment 19•11 years ago
|
||
This is live now.
I will close it as soon as I see them running.
TryChooser has also been updated.
[root@relengweb1.dmz.scl3 tools]# hg id
c92f9eb6f601 tip
[root@relengweb1.dmz.scl3 tools]# hg pull -u && hg up -C && hg id
pulling from http://hg.mozilla.org/build/tools
searching for changes
adding changesets
adding manifests
adding file changes
added 21 changesets with 33 changes to 21 files
21 files updated, 0 files merged, 0 files removed, 0 files unresolved
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
db1d47944f57 tip
Assignee | ||
Comment 20•11 years ago
|
||
Attachment #762073 -
Flags: review?(emorley)
Assignee | ||
Comment 21•11 years ago
|
||
I *just* merged the changes from default to production on mozharness.
Those jobs that happened before this are going to appear green but did not actually run anything.
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&showall=1&jobname=metro
We can see a passing opt job:
https://tbpl.mozilla.org/php/getParsedLog.php?id=24108037&tree=Mozilla-Inbound&full=1
Assignee | ||
Comment 22•11 years ago
|
||
A bunch of timeouts on the debug jobs:
https://tbpl.mozilla.org/php/getParsedLog.php?id=24108378&tree=Mozilla-Inbound&full=1
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&showall=1&jobname=debug.*metro
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment #762073 -
Flags: review?(emorley) → review+
Assignee | ||
Updated•11 years ago
|
Attachment #762073 -
Flags: checked-in+
Assignee | ||
Comment 23•11 years ago
|
||
Could you please let us know when this change goes live? (I can't find releng instructions on how to do so).
https://hg.mozilla.org/webtools/tbpl/rev/c60dada1c549
Thanks!
Flags: needinfo?(emorley)
Comment 24•11 years ago
|
||
(In reply to Armen Zambrano G. [:armenzg] (back in July 7th) from comment #23)
> Could you please let us know when this change goes live? (I can't find
> releng instructions on how to do so).
> https://hg.mozilla.org/webtools/tbpl/rev/c60dada1c549
>
> Thanks!
Will do a prod push now (preferred option is to ask me to do a prod push to ensure staged but not ready changes don't get pushed along with the rest, but in an emergency webops can do it). Which wiki pages should I update with instructions?
Flags: needinfo?(emorley)
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Updated•8 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•