Closed
Bug 882712
Opened 11 years ago
Closed 10 years ago
Point tooltool to tooltool virtualhosts
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: coop)
References
Details
(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2639] )
Attachments
(5 files, 1 obsolete file)
(deleted),
patch
|
dustin
:
review+
coop
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dustin
:
review+
coop
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dustin
:
review+
coop
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dustin
:
review+
coop
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dustin
:
review+
|
Details | Diff | Splinter Review |
Per bug 768879, we have virtualhosts set up that are dedicated to tooltool. However, in production, tooltool is still looking at http://runtime-binaries.pvt.build.mozilla.org.
The two are serving files from the same directory, so they're identical, but moving to the vhosts will give us the ability to quickly re-host that service on other servers if load dictates. It also eliminates some confusion in the web server configuration.
Given the code changes in bug 768123, this should just be a configuration change, adding
http://tooltool.pvt.build.mozilla.org/build
http://tooltool.pub.build.mozilla.org/try
or whatever folders you'd prefer to use (I guessed about try) to the configuration, and removing runtime-binaries.
Reporter | ||
Updated•11 years ago
|
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Reporter | ||
Comment 1•11 years ago
|
||
Simone, I think you're planning to do this -- but I don't see you assigned. Am I wrong?
Comment 2•11 years ago
|
||
Hi Dustin, yes, this will be part of the landing of Bug 768123: once we make sure that the correct version of tooltool is used in all machines, we can use the two new servers replacing in all tooltool invocation the "runtime binaries" server with the appropriate one(s).
The landing of this is intertwined with the landing of all other changes applied to tooltool in the past months, so it is tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=920485 (which is assigned to me).
Updated•11 years ago
|
Assignee: nobody → sbruno
Comment 3•11 years ago
|
||
I guess it makes sense to assign this to myself as well!
Comment 4•10 years ago
|
||
Dustin: runtime-binaries.pvt.build.mozilla.org and tooltool.pvt.build.mozilla.org seem to be pointing to the same host, would you still want to replace all runtime-binaries references to tooltool.pvt.build.mozilla.org?
Flags: needinfo?(dustin)
Reporter | ||
Comment 5•10 years ago
|
||
Yes, they're different virtualhosts, and runtime-binaries is not the correct choice.
Assignee | ||
Updated•10 years ago
|
Assignee: sbruno → nobody
Updated•10 years ago
|
Flags: needinfo?(dustin)
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2632]
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2632] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2639]
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → coop
Status: NEW → ASSIGNED
Priority: -- → P2
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8535787 -
Flags: review?(dustin)
Reporter | ||
Updated•10 years ago
|
Attachment #8535787 -
Flags: review?(dustin) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8535787 [details] [diff] [review]
[buildbot-configs] Switch from runtime-binaries to tooltool
Review of attachment 8535787 [details] [diff] [review]:
-----------------------------------------------------------------
https://hg.mozilla.org/build/buildbot-configs/rev/db767bbeae20
Attachment #8535787 -
Flags: checked-in+
Assignee | ||
Comment 8•10 years ago
|
||
There are also lots of examples of runtimes-binaries being used in mozharness. Should I fix those up too?
Reporter | ||
Comment 9•10 years ago
|
||
If they're being used for tooltool, yeah.
I think there are a few miscellaneous uses of runtime-binaries for non-tooltool purposes. If so, those can stay. If not, we'll kill the vhost. We'll be able to tell from access logs.
Assignee | ||
Comment 10•10 years ago
|
||
Assignee | ||
Comment 11•10 years ago
|
||
Attachment #8537934 -
Flags: review?(dustin)
Reporter | ||
Comment 12•10 years ago
|
||
Comment on attachment 8537934 [details] [diff] [review]
[mozharness] Switch from runtime-binaries to tooltool
Review of attachment 8537934 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not too familiar with mozharness, but the search-and-replace looks solid.
Attachment #8537934 -
Flags: review?(dustin) → review+
Assignee | ||
Comment 13•10 years ago
|
||
Comment on attachment 8537934 [details] [diff] [review]
[mozharness] Switch from runtime-binaries to tooltool
Review of attachment 8537934 [details] [diff] [review]:
-----------------------------------------------------------------
https://hg.mozilla.org/build/mozharness/rev/f215541c63b6
Attachment #8537934 -
Flags: checked-in+
Comment 14•10 years ago
|
||
In production: https://hg.mozilla.org/build/mozharness/rev/f215541c63b6
Assignee | ||
Comment 15•10 years ago
|
||
Missed a few things with the previous patch, mostly around proxxy. Follow-up patches coming shortly.
Assignee | ||
Comment 16•10 years ago
|
||
Attachment #8538521 -
Flags: review?(dustin)
Assignee | ||
Comment 17•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8538524 -
Flags: review?(dustin)
Assignee | ||
Comment 18•10 years ago
|
||
This is the only example I can find in-tree of us calling runtime-binaries directly.
Attachment #8538525 -
Flags: review?(dustin)
Reporter | ||
Updated•10 years ago
|
Attachment #8538521 -
Flags: review?(dustin) → review+
Reporter | ||
Comment 19•10 years ago
|
||
Comment on attachment 8538524 [details] [diff] [review]
[puppet] Switch from runtime-binaries to tooltool for proxxy
Review of attachment 8538524 [details] [diff] [review]:
-----------------------------------------------------------------
Do you want to keep both of these entries in place during the transition?
Reporter | ||
Comment 20•10 years ago
|
||
Comment on attachment 8538525 [details] [diff] [review]
[mozilla-inbound] Switch from runtime-binaries to tooltool
Review of attachment 8538525 [details] [diff] [review]:
-----------------------------------------------------------------
I don't even know what repo this is in, but hey, looks good :)
Attachment #8538525 -
Flags: review?(dustin) → review+
Assignee | ||
Comment 21•10 years ago
|
||
(In reply to Dustin J. Mitchell [:dustin] from comment #19)
> Do you want to keep both of these entries in place during the transition?
Yes. That's probably a good idea.
Assignee | ||
Comment 22•10 years ago
|
||
Preserve runtime-binaries while we transition.
Attachment #8538789 -
Flags: review?(dustin)
Assignee | ||
Updated•10 years ago
|
Attachment #8538524 -
Attachment is obsolete: true
Attachment #8538524 -
Flags: review?(dustin)
Assignee | ||
Comment 23•10 years ago
|
||
Comment on attachment 8538525 [details] [diff] [review]
[mozilla-inbound] Switch from runtime-binaries to tooltool
Review of attachment 8538525 [details] [diff] [review]:
-----------------------------------------------------------------
https://hg.mozilla.org/integration/mozilla-inbound/rev/c772701d6d62
Attachment #8538525 -
Flags: checked-in+
Assignee | ||
Comment 24•10 years ago
|
||
Comment on attachment 8538521 [details] [diff] [review]
[mozharness] Switch from runtime-binaries to tooltool for proxxy
Review of attachment 8538521 [details] [diff] [review]:
-----------------------------------------------------------------
https://hg.mozilla.org/build/mozharness/rev/f05a3b9237d8
Attachment #8538521 -
Flags: checked-in+
Comment 25•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•10 years ago
|
Attachment #8538789 -
Flags: review?(dustin) → review+
Reporter | ||
Comment 26•10 years ago
|
||
THANKS COOP! :)
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•