EXTRA_DSO_LIBS is only used in a few places, and in most it's cut-and-paste worthlessness. rules.mk expands EXTRA_DSO_LIBS to EXPAND_MOZLIBNAME,$(EXTRA_DSO_LIBS) -- but it's not referenced in any rules directly

Yep, we can just remove EXTRA_DSO_LDOPTS. It's not referenced in any rules, and was always explicitly added to LIBS when it actually had an effect. It only had an effect in one spot, where XUL was explicitly added right after anyway (for OSX). In a bunch of places things were assigned to it, but it wasn't used anywhere and had no effect on the build. Try results: https://tbpl.mozilla.org/?tree=Try&rev=f81fe94b1587

Comment on attachment 762713 [details] [diff] [review] remove EXTRA_DSO_LIBS Review of attachment 762713 [details] [diff] [review]: ----------------------------------------------------------------- I totally just wrote this same patch. Awesome.

Comment on attachment 762713 [details] [diff] [review] remove EXTRA_DSO_LIBS cut & paste expansion and removal looks fine. Was libxul needed while linking startupcache/test ? xul was removed from there w/o replacement.

Joey: note that EXTRA_DSO_LIBS wasn't actually functional--nothing in rules.mk ever put its value into the link line. This must have been removed a while back and nobody did the cleanup work that Vlad did here.