Comment on attachment 762875 [details] [diff] [review] move SDK_LIBRARY to mozbuild (logic). Add SDK_LIBRARY as a passthrough variable.

Comment on attachment 764134 [details] [diff] [review] move SDK_LIBRARY to mozbuild (logic). rebase, r=gps carried forward.

Comment on attachment 764134 [details] [diff] [review] move SDK_LIBRARY to mozbuild (logic). Pushed to inbound: committed changeset 135455:d4518f89e75a https://hg.mozilla.org/integration/mozilla-inbound/rev/d4518f89e75a

added leave-open whiteboard tag for the upcoming converted file patch.

Comment on attachment 770303 [details] [diff] [review] move SDK_LIBRARY to mozbuild (file batch #1). http://tbpl.mozilla.org/?tree=Try&rev=40636e0bb9b1 timeout on osx 10.7 opt build. pand and unagi having problems with missing png library symbols, likely a conditional problem in a mozbuild file.

(In reply to Joey Armstrong [:joey] from comment #10) > Comment on attachment 770303 [details] [diff] [review] > move SDK_LIBRARY to mozbuild (file batch #1). > > http://tbpl.mozilla.org/?tree=Try&rev=40636e0bb9b1 > > timeout on osx 10.7 opt build. > pand and unagi having problems with missing png library symbols, likely a > conditional problem in a mozbuild file. media/libpng/arm/arm_init.c not referenced by Makefile.in is also the likely source for this failure.

Lingering var references % find . -name "Makefile.in" | xargs grep SDK_LIBRARY ./js/src/Makefile.in:SDK_LIBRARY = $(IMPORT_LIBRARY) ./js/src/Makefile.in:SDK_LIBRARY = $(SHARED_LIBRARY) ./mozglue/build/Makefile.in:SDK_LIBRARY = $(IMPORT_LIBRARY) ./mozglue/build/Makefile.in:SDK_LIBRARY = $(SHARED_LIBRARY) ./mozglue/build/Makefile.in:SDK_LIBRARY = $(REAL_LIBRARY) ./xpcom/glue/standalone/Makefile.in:SDK_LIBRARY = \ ./xpcom/glue/standalone/staticruntime/Makefile.in:SDK_LIBRARY = \ ./xpcom/glue/nomozalloc/Makefile.in:SDK_LIBRARY = \ ./xpcom/glue/Makefile.in:SDK_LIBRARY = \ ./xpcom/glue/staticruntime/Makefile.in:SDK_LIBRARY = \ ./memory/mozalloc/Makefile.in:SDK_LIBRARY = $(IMPORT_LIBRARY) ./memory/mozalloc/Makefile.in:SDK_LIBRARY = $(SHARED_LIBRARY) ./memory/build/Makefile.in:SDK_LIBRARY = $(REAL_LIBRARY) ./memory/jemalloc/Makefile.in:SDK_LIBRARY = $(REAL_LIBRARY) ./toolkit/library/Makefile.in:SDK_LIBRARY = $(IMPORT_LIBRARY) ./toolkit/library/Makefile.in:SDK_LIBRARY = $(SHARED_LIBRARY) ./toolkit/library/Makefile.in: $(MAKE) libs SHARED_LIBRARY_NAME=gtest/$(EFFECTIVE_LIB_PREFIX)$(LIBRARY_NAME) FINAL_TARGET=$(FINAL_TARGET)/gtest SDK_LIBRARY= IMPORT_LIB_DEST=$(IMPORT_LIB_DEST)/gtest LINK_GTEST=true ./intl/unicharutil/util/Makefile.in:SDK_LIBRARY = $(LIBRARY)

Comment on attachment 806041 [details] [diff] [review] move SDK_LIBRARY to mozbuild. try-build job: http://tbpl.mozilla.org/?tree=Try&rev=7a9f97ba2438

Comment on attachment 806041 [details] [diff] [review] move SDK_LIBRARY to mozbuild. Review of attachment 806041 [details] [diff] [review]: ----------------------------------------------------------------- convert xpcom::SDK_LIBRARY linux64-opt-GU/gaia test failure reported as a missing activeKeyboard or keyboard language. Retest to see if the failure is repeatable.

re-try linux64-opt: http://tbpl.mozilla.org/?tree=Try&rev=32e008c7937d

Comment on attachment 806041 [details] [diff] [review] move SDK_LIBRARY to mozbuild. Looks good to me!

Inbound push for patch #1: http://hg.mozilla.org/integration/mozilla-inbound/rev/120d13ba7b71

(In reply to Joey Armstrong [:joey] from comment #16) > re-try linux64-opt: http://tbpl.mozilla.org/?tree=Try&rev=32e008c7937d Transient failure, linux64 passed on 2nd attempt.

ignore, wrong bug.

Can I take the rest of this bug?

One question: there are places where we set the SDK_LIBRARY variable to either $(IMPORT_LIBRARY) or $(SHARED_LIBRARY) depending on the platform. Those two variables are set in config/rules.mk, so I think they are unavailable in moz.build files. What is the right way of porting those kinds of variables to moz.build?

Wait a few days and there will be a new variable with either IMPORT_LIBRARY or SHARED_LIBRARY

Actually, come to think of it, it's just better to make it a boolean. Either the lib is in the sdk or it's not. It should be the build system's task to figure out what specific file that needs to be.