Closed
Bug 887524
Opened 11 years ago
Closed 11 years ago
Move IDBRequest to WebIDL
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: ehsan.akhgari, Assigned: baku)
References
(Blocks 1 open bug)
Details
(Keywords: addon-compat, dev-doc-complete, site-compat)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
janv
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•11 years ago
|
Assignee: ehsan → amarchesini
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #783691 -
Flags: review?(Jan.Varga)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 783691 [details] [diff] [review]
request.patch
Review of attachment 783691 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/indexedDB/IDBRequest.cpp
@@ +24,5 @@
> #include "IDBEvents.h"
> #include "IDBFactory.h"
> #include "IDBTransaction.h"
>
> +#include "mozilla/dom/IDBOpenDBRequestBinding.h"
Nit: this should go before |#include "nsComponentManagerUtils.h"|
::: dom/indexedDB/IDBRequest.h
@@ +6,5 @@
>
> #ifndef mozilla_dom_indexeddb_idbrequest_h__
> #define mozilla_dom_indexeddb_idbrequest_h__
>
> +
Nit: remove this empty line
@@ +19,1 @@
> #include "mozilla/dom/DOMError.h"
#include "mozilla/dom/indexedDB/IndexedDatabase.h"
#include "mozilla/Attributes.h"
#include "mozilla/dom/DOMError.h"
#include "mozilla/dom/IDBRequestBinding.h"
#include "mozilla/ErrorResult.h"
#include "nsCycleCollectionParticipant.h"
#include "nsWrapperCache.h"
#include "mozilla/dom/indexedDB/IDBWrapperCache.h"
@@ +116,5 @@
> + GetResult(JSContext* aCx, ErrorResult& aRv) const;
> +
> + nsISupports*
> + GetSource() const
> + {
add the main thread assertion, here and below
::: dom/indexedDB/ipc/IndexedDBParent.cpp
@@ +383,5 @@
>
> AutoSafeJSContext cx;
>
> + ErrorResult error;
> + JS::Value result = mOpenRequest->GetResult(cx, error);
Is this safe ?
I would expect something like:
JS::Rooted<JS::Value> result ...
Attachment #783691 -
Flags: review?(Jan.Varga)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #783691 -
Attachment is obsolete: true
Attachment #783798 -
Flags: review?(Jan.Varga)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 783798 [details] [diff] [review]
request.patch
r=me
Attachment #783798 -
Flags: review?(Jan.Varga) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Keywords: dev-doc-needed
|
|
Assignee | |
Comment 7•11 years ago
|
||
IDBRequest.LOADING and IDBRequest.DONE are gone. Documentation must be updated.
|
||
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
|
||
Comment 9•11 years ago
|
||
https://developer.mozilla.org/en-US/docs/Web/API/IDBRequest#Constants
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility
OS: Mac OS X → All
Hardware: x86 → All
|
||
Updated•10 years ago
|
Depends on: CVE-2015-2728
You need to log in
before you can comment on or make changes to this bug.
Description
•