Closed Bug 888601 Opened 11 years ago Closed 11 years ago

Panorama (Tab Groups) icon needed in proper sizes

Categories

(Firefox :: Theme, defect)

All
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: u428464, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Keywords: icon, polish, Whiteboard: [Australis:P3])

Attachments

(3 files)

After the landing of bug 875488 the panorama icon has been switched back to the old version. It doesn't look good. The new one should be reimplemented.
Whiteboard: [Australis:M?]
Version: Trunk → unspecified
The icons look identical to me on OS X retina, between Nightly and latest UX. Which platform/OS are you seeing this on?
Windows when the icon is in the menu panel or in the customization palette. Stephen mentioned that he will update the spritesheet to add it back in bug 875488 comment 9.
This sounds like visual polish which isn't the worst of our problems right now -> P4.
OS: All → Windows 7
Whiteboard: [Australis:M?] → [Australis:M?][Australis:P4]
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: icon, polish
Whiteboard: [Australis:M?][Australis:P4] → [Australis:M?][Australis:P3]
Assignee: nobody → shorlander
Attached image Screenshot of the issue (deleted) —
For the record, this is how it looks like on Win7 at the moment. The tab group icon is the only one that looks blurry.
Note that the icon in the list all tab menu should be updated too.
This is terribly blurry on Retina, and sounds like it's wrong on normal-dpi Windows too.

Steven, can we get an icon?
Flags: needinfo?(shorlander)
Summary: Add back the proper panorama icon → Panaroma icon needed in proper sizes
Whiteboard: [Australis:M?][Australis:P3] → [Australis:P3]
Per Stephen, Michael, could you take this too? :-)
Assignee: shorlander → mmaslaney
Flags: needinfo?(shorlander)
Summary: Panaroma icon needed in proper sizes → Panorama (Tab Groups) icon needed in proper sizes
Attached file Toolbars.zip (deleted) —
Tab icon now attached to Toolbar.png
Assignee: mmaslaney → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Boom.
Attachment #8361757 - Flags: review?(jaws)
Comment on attachment 8361757 [details] [diff] [review]
update panorama icons for Australis,

Review of attachment 8361757 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/browser.inc
@@ +1,3 @@
>  %filter substitution
>  
> +%define primaryToolbarButtons #back-button, #forward-button, #home-button, #print-button, #downloads-button, #bookmarks-menu-button, #new-tab-button, #new-window-button, #cut-button, #copy-button, #paste-button, #fullscreen-button, #zoom-out-button, #zoom-reset-button, #zoom-in-button, #sync-button, #feed-button, #webrtc-status-button, #social-share-button, #open-file-button, #find-button, #developer-button, #preferences-button, #privatebrowsing-button, #save-page-button, #switch-to-metro-button, #add-ons-button, #history-panelmenu, #nav-bar-overflow-button, #PanelUI-menu-button, #characterencoding-button, #tabview-button, #email-link-button

Can you please put the #tabview-button so it is following the #feed-button? This will revert this file back to the state that it was prior to the #tabview-button being removed.
Attachment #8361757 - Flags: review?(jaws) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/5324dac4d4b4
Whiteboard: [Australis:P3] → [Australis:P3][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5324dac4d4b4
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 29
Depends on: 983996
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: