Closed
Bug 956994
Opened 11 years ago
Closed 11 years ago
Tab Groups button increases toolbar height
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 29
People
(Reporter: jkitch, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [Australis:P4][fixed by bug 888601])
Moving the "Tag Groups" button onto the nav toolbar marginally increases the nav toolbar's height (on Windows at least). Of the buttons present in the stock configuration, it seems to be the only one that does it.
Reporter | ||
Updated•11 years ago
|
Blocks: australis-merge
Assignee | ||
Updated•11 years ago
|
Blocks: australis-cust
Component: Toolbars and Customization → Theme
Flags: needinfo?(gijskruitbosch+bugs)
Whiteboard: [Australis:P4]
Assignee | ||
Comment 1•11 years ago
|
||
Jared, this was caused by bug 956130 because the tab groups icon is now no longer part of the main set of toolbar button icons and so we increase the padding for it in http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#478 . Why was the button removed from the set of primary toolbar buttons? IMO the right solution would be to incorporate the icon in the main toolbar button set, and likewise in the menuPanel sets for display there, rather than upscaling the existing icon...
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(jaws)
Updated•11 years ago
|
Keywords: regression
Comment 2•11 years ago
|
||
This was fixed by bug 888601.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(jaws)
Resolution: --- → FIXED
Whiteboard: [Australis:P4] → [Australis:P4][fixed by bug 888601]
Updated•11 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Target Milestone: --- → Firefox 29
You need to log in
before you can comment on or make changes to this bug.
Description
•