Closed
Bug 888783
Opened 11 years ago
Closed 10 years ago
PRenderFrame should not allocate PLayerTransaction
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
DUPLICATE
of bug 1056427
People
(Reporter: dzbarsky, Assigned: dzbarsky)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Assignee | ||
Updated•11 years ago
|
Attachment #769531 -
Flags: review?(matt.woodrow)
Assignee | ||
Updated•11 years ago
|
Attachment #769531 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 2•11 years ago
|
||
Need to move the ipc mochitests to their own test suite first.
https://tbpl.mozilla.org/?tree=Try&rev=66241bc14cb9
Attachment #769531 -
Attachment is obsolete: true
Attachment #769569 -
Flags: review?(matt.woodrow)
Comment 3•11 years ago
|
||
Comment on attachment 769569 [details] [diff] [review]
Patch
Review of attachment 769569 [details] [diff] [review]:
-----------------------------------------------------------------
Awesome. Hope you can get the tests sorted out so that this passes.
Attachment #769569 -
Flags: review?(matt.woodrow) → review+
Comment 4•11 years ago
|
||
http://mxr.mozilla.org/mozilla-central/source/layout/ipc/RenderFrameParent.cpp#611
This branch should be an assert too.
Assignee | ||
Comment 5•11 years ago
|
||
It doesn't really make sense to be doing this. By turning off remote frames we lose some test coverage, but it should be ok because the tests are cross-platform and will still run on platforms with OMTC. I've talked to dvander and billm and they're ok with this.
Attachment #785927 -
Flags: review?(matt.woodrow)
Comment 6•11 years ago
|
||
Comment on attachment 785927 [details] [diff] [review]
Part 0: Disable remote frames when OMTC is disabled
Sorry, I don't think I can make this call :(
Deferring to a super-reviewer, but it might make sense to have the owners of the tests weight in too.
Attachment #785927 -
Flags: review?(matt.woodrow) → review?(roc)
Won't this break the e10s thumbnailing stuff that's turned on now?
Assignee | ||
Comment 8•11 years ago
|
||
How does the e10s thumbnailing render anything on platforms without OMTC? I don't think we do anything useful with the layers transactions that come through RenderFrameParent
Comment 9•11 years ago
|
||
It doesn't render anything to a real window. It just does drawWindow calls within the process. The Compositor/RenderFrame etc connections aren't doing anything useful.
Right. Layers transactions already aren't coming through for those e10s thumbnailing windows on non-OMTC platforms, but that's fine. But this patch will make them stop being remote altogether, which is not fine.
Assignee | ||
Comment 11•11 years ago
|
||
Ok, I think we can fix tests to not try to create remote iframes without OMTC but still allow the thumbnailing service to do its thing.
Assignee | ||
Updated•11 years ago
|
Attachment #785927 -
Attachment is obsolete: true
Attachment #785927 -
Flags: review?(roc)
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•