This is legacy code from before we had a compositor thread. There's a lot of dead code in here, and I think we can get rid of most of it.

There's probably a lot more we can do, but this is a good start.

Fixed the assertion, trying again: https://tbpl.mozilla.org/?tree=Try&rev=69805cf865e4

Comment on attachment 8476383 [details] [diff] [review] Remove PLayerTransaction from PRenderFrame Review of attachment 8476383 [details] [diff] [review]: ----------------------------------------------------------------- Wow! Please file a followup bug (or bugs) for any more stuff you know can be removed.

Unfortunately the previous version didn't work, the tests just hang. I couldn't really be bothered spending too much time debugging it, so instead I've just made us create the compositor thread unconditionally so we can always take those code paths. This shouldn't be much overhead, and we'll be wanting it everywhere soon enough anyway.

And removed the pref change that wasn't meant to be there

Comment on attachment 8476555 [details] [diff] [review] Remove PLayerTransaction from PRenderFrame v3 Review of attachment 8476555 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/client/ClientLayerManager.cpp @@ +510,4 @@ > } else if (HasShadowManager()) { > NS_WARNING("failed to forward Layers transaction"); > } > + trailing whitespace