Closed
Bug 888826
Opened 11 years ago
Closed 11 years ago
(regression) panda android no longer setting shutdown.stamp for graceful shutdown of buildbot
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Callek, Assigned: kmoir)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mozilla
:
review+
kmoir
:
checked-in+
|
Details | Diff | Splinter Review |
So we recently changed the android jobs to touch shutdown.stamp in order to graceful themselves between jobs rather than forcibly kill themselves when we see the error.flg.
It seems Panda Android on Mozharness has regressed this by no longer touching the shutdown.stamp file.
It was added in http://hg.mozilla.org/build/buildbotcustom/rev/ac664092d9d8 back in May. Kim is this something you think can be fixed easily?
At the moment there is nothing that will stop a panda job from running even when it won't ping due to this issue.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → kmoir
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #770190 -
Flags: review?(aki)
Comment 2•11 years ago
|
||
Comment on attachment 770190 [details] [diff] [review]
patch
The shutdown_dir could be specified in query_abs_dirs(), but this works too.
Attachment #770190 -
Flags: review?(aki) → review+
Assignee | ||
Comment 3•11 years ago
|
||
thanks aki for the suggestion, that's a cleaner way to do this
Attachment #770190 -
Attachment is obsolete: true
Attachment #770318 -
Flags: review?(aki)
Comment 4•11 years ago
|
||
Comment on attachment 770318 [details] [diff] [review]
patch
>+ shutdown_file = os.path.join(dirs['shutdown_dir'],'shutdown.stamp')
Nit: You'll probably get a pep8 warning unless you put a space after the comma.
>+ open(shutdown_file, 'w').close()
A couple things:
a) I wish this were logged (open() is silent by default)
b) we may at some point need to bypass this for developer non-buildbot test runs.
Sorry I didn't catch those two things the first time around.
I'm ok with this landing as-is, but we may have to address them in the future.
Attachment #770318 -
Flags: review?(aki) → review+
Assignee | ||
Comment 5•11 years ago
|
||
added logging + fixed all the pep8 errors in that script
Attachment #770318 -
Attachment is obsolete: true
Attachment #770380 -
Flags: review?(aki)
Comment 6•11 years ago
|
||
Comment on attachment 770380 [details] [diff] [review]
patch
Thanks Kim!
Attachment #770380 -
Flags: review?(aki) → review+
Assignee | ||
Updated•11 years ago
|
Attachment #770380 -
Flags: checked-in+
Comment 7•11 years ago
|
||
Comment on attachment 770380 [details] [diff] [review]
patch
in production
Assignee | ||
Comment 8•11 years ago
|
||
Verified that this is working on a recent build on tbpl.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•