(no longer active) Assignee
	Description • 11 years ago

      No description provided.

	(no longer active) Assignee
	Comment 1 • 11 years ago

The current event doesn't adhere to the spec (it's missing the ctor).

	(no longer active) Assignee
	Comment 3 • 11 years ago

http://hg.mozilla.org/integration/mozilla-inbound/rev/170e1863b9b6

	(no longer active) Assignee
	Comment 4 • 11 years ago

Backed out because of xpcshell test failures <https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=170e1863b9b6>

http://hg.mozilla.org/integration/mozilla-inbound/rev/e0010026c9e5

	(no longer active) Assignee
	Comment 5 • 11 years ago

I cannot reproduce the test failure locally.  Do any of you guys have an idea why?

	Masatoshi Kimura [:emk]
	Comment 6 • 11 years ago

Because the IDBVersionChangeEvent constructor is not defined on the xpcshell global?
Rather, I'm surprised that the test doesn't fail locally.

	Jan Varga [:janv]
	Comment 7 • 11 years ago

TEST_PATH=dom/indexedDB/test/unit/test_setVersion_events.js EXTRA_TEST_ARGS=--verbose make xpcshell-tests

TEST-PASS | /Users/varga/Sources/Marvin/obj-ff-dbg/_tests/xpcshell/dom/indexedDB/test/unit/test_setVersion_events.js | [testSteps : 158] 3 == 3
JS Component Loader: ERROR /Users/varga/Sources/Marvin/obj-ff-dbg/_tests/xpcshell/dom/indexedDB/test/unit/test_setVersion_events.js:160
                     TypeError: IDBVersionChangeEvent is not a constructor
<<<<<<<
TEST-UNEXPECTED-FAIL | Received SIGINT (control-C) during test execution

	Jan Varga [:janv]
	Comment 8 • 11 years ago

This fix works perfectly (thanks to bz).

It actually seems that we can get rid of InitWindowless() altogether!

	(no longer active) Assignee
	Comment 9 • 11 years ago

Thanks!

	(no longer active) Assignee
	Comment 10 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/44f8f3e450bc

	Jan Varga [:janv]
	Comment 11 • 11 years ago

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #10)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/44f8f3e450bc

I had to comment out |const IDBVersionChangeEvent = Ci.nsIIDBVersionChangeEvent| in dom/indexedDB/test/unit/head.js

That's a part of bug 890405, I thought you would land that one first.

	Jan Varga [:janv]
	Comment 12 • 11 years ago

oh, never mind, the changeset contains the fix

	(no longer active) Assignee
	Comment 13 • 11 years ago

(In reply to comment #12)
> oh, never mind, the changeset contains the fix

Yeah, I'm still waiting for a review on that bug...

	Ryan VanderMeulen [:RyanVM]
	Comment 14 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/44f8f3e450bc