Closed
Bug 892110
Opened 11 years ago
Closed 10 years ago
Text/label for canceling mouse pointer lock doorhanger with ESC key doesn't linewrap, gets cropped, but popup is bigger
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
People
(Reporter: aryx, Assigned: Gijs)
References
()
Details
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
screenshot of issue
Tested on latest Firefox Nightly and Beta, with Windows XP SP3 32 bit
In some localized builds (e.g. German), the label for canceling the point lock with the ESC key doesn't fit into one line, but it doesn't get line-wrapped - it get's cropped. But the popup is wider than normal, see screenshot.
Test page:
http://mozilla.pettay.fi/moztests/pointerlock.html
|
Reporter | |
Updated•10 years ago
|
Summary: Text/label for canceling pointer lock doorhanger with ESC key doesn't linewrap, gets cropped, but popup is bigger → Text/label for canceling mouse pointer lock doorhanger with ESC key doesn't linewrap, gets cropped, but popup is bigger
|
||
Comment 4•10 years ago
|
||
That popup is coming from FF UI.
Perhaps Tim knows something about it.
Flags: needinfo?(bugs) → needinfo?(ttaubert)
|
||
Comment 5•10 years ago
|
||
Looks like some CSS issue that shouldn't be hard to fix. I wonder if that affects other languages or popups. Putting in the Firefox backlog so that we can prioritize it.
Flags: needinfo?(ttaubert) → firefox-backlog+
|
||
Comment 6•10 years ago
|
||
Based on this, it affects a ton of languages
http://transvision.mozfr.org/string/?entity=browser/chrome/browser/browser.dtd:pointerLock.notification.message&repo=aurora
|
Assignee | |
Comment 7•10 years ago
|
||
Ran into this via the dupe because I watch untriaged. We just need to make the label the kid of the <label> element instead of putting it in the value attribute. Tested on OS X with an extra-long label, this seems to work.
Attachment #8512273 -
Flags: review?(ttaubert)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 8•10 years ago
|
||
Marco, can you add this (see comment #7) to next iteration, considering it's late on Monday? :-)
Iteration: --- → 36.2
Points: --- → 1
Flags: qe-verify-
Flags: needinfo?(mmucci)
Flags: in-testsuite-
|
||
Updated•10 years ago
|
Flags: needinfo?(mmucci)
|
|
||
Updated•10 years ago
|
Attachment #8512273 -
Flags: review?(ttaubert) → review+
|
|
Assignee | |
Comment 9•10 years ago
|
||
OS: Windows XP → All
Hardware: x86 → All
Whiteboard: [fixed-in-fx-team]
|
||
Comment 10•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
You need to log in
before you can comment on or make changes to this bug.
Description
•