Open
Bug 89308
Opened 24 years ago
Updated 2 years ago
Open context menus on mousedown in Windows
Categories
(Core :: XUL, enhancement)
Tracking
()
NEW
Future
People
(Reporter: binarycowboy, Unassigned)
References
Details
This is a continuation from bug 49844. While that bug has turned into a general holy war about whether or not context menus should even appear on mouse down, this bug should be to discuss patches that allow mouse down behavior in windows. The current patch up for scrutinizing is available here: http://bugzilla.mozilla.org/showattachment.cgi?attach_id=41135 (created as an attchment to 49844)
Updated•24 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 1•24 years ago
|
||
Certainly the current implementation is wrong because a right-drag shows the context menu for the target. I'm sure it would be easier just to open the menu on the mouse down since browsers don't need to right-drag, do they?
those kinds of questions should go in bug 49844, this bug is for discussing actual patches (as in, "hey, that patch sucks because it slows down the browser by 30%").
Comment 3•24 years ago
|
||
To re-emphasize what Brian said for all to read, this bug is not for discussion of mouse-down vs. mouse-up. Bug 49844 became useless because of all of the crud in it. This bug exists because there is a potential patch that needs further investigation. Take discussions of the interface to n.p.m.ui if you need to.
Updated•24 years ago
|
Updated•23 years ago
|
Target Milestone: --- → Future
Comment 7•23 years ago
|
||
Transferring keywords from bug 49844, since it was marked as a dup of this one. Reading the patch, two questions. First, why are you referencing a pref? Is anyone who prefers the current behavior going to be using the patch anyway? Second, the patch doesn't seem to contain code for opening on Shift+F10 or the context menu key on the keyboard. You'll need to take care of both of those if you're reimplementing WM_CONTEXTMENU, right?
Comment 8•23 years ago
|
||
The context menu key code looks to still be in there: case WM_CONTEXTMENU: .... + if (lParam == 0xFFFFFFFF){ + result = DispatchMouseEvent(NS_CONTEXTMENU_KEY); I'm not sure if this is what handles Shift+F10 as well. Brian, have you tested to make sure you can still pop up a context menu with the keyboard, using both Shift+F10 and the context menu key? As for the pref, I think that due to the opposition from certain parties of moving this behavior from mouse-up to mouse-down, the only way to get this code in would be to make it optional.
Comment 12•23 years ago
|
||
Windows users might actually need right-drag for bug 76537 (Gestures). There's a work in progress implementation (http://optimoz.mozdev.org). Personally, I do think onMouseDown is appropriate for the context menu, but would request that this be configurable -- not in the prefs panel, but at some lower level, so that if a user could choose to use gestures and bind them to right-click-drag, the context menu could be set to mouseUp.
Comment 15•23 years ago
|
||
[Aufbau-P3]: context menus are important for surfing with one hand, which in turn is important for porn surfing.
Whiteboard: [Aufbau-P3]
Updated•23 years ago
|
Whiteboard: [Aufbau-P3]
Comment 18•23 years ago
|
||
Personally I'd like to have this configurable (even a hidden prev), because I like the windows behavior and I'd like to have on linux also. Someday I'd like to have drag'n'drop using the right button instead of the left... see bug 25742
Comment 19•23 years ago
|
||
As seen in bug 49844 and others, both Netscape 4.x and Microsoft Office (XP included) are showing: - sometimes a context menu on mousedown (for example toolbars) - sometimes a context menu on mouseup (for example text editing) Everyone (that I can see) agrees the mousedown way is more usable. So the correct behaviour seems to me: - when mousedown is required for something else (dragging something, mouse gestures activated, ...) the context menu should fire on mouseup - everywhere else it should appear on mousedown So I don't think there should be a "global pref", there are cases described when mousedown is *not* possible. But where it is possible, mousedown is definately *better*.
Comment 22•22 years ago
|
||
So, how'd we move on with this bug? Making a hidden pref sounds reasonable to me, since then the bug 167271 could be also be fixed by changing this pref with gestures installation. I saw many complains about it on Newsgroups: netscape.netscape7.windows. Any thoughts?
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
Comment 27•2 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: binarycowboy → nobody
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•