Armen [:armenzg] Reporter
	Description • 11 years ago

I duplicated the code from here:
http://hg.mozilla.org/build/buildbotcustom/file/170c45c657c0/misc.py#l1850
into here:
http://hg.mozilla.org/build/buildbotcustom/file/170c45c657c0/misc.py#l1922

Could you please help with this?

I would also prefer if some of extraArgs logic moves into PLATFORMS in here:
http://hg.mozilla.org/build/buildbot-configs/file/default/mozilla-tests/config.py#l85

	Jason Yeo[:jyeo] Assignee
	Comment 2 • 11 years ago

Is there any way to make sure that everything is okay? How do I test misc.py?

	Armen [:armenzg] Reporter
	Comment 3 • 11 years ago

Comment on attachment 785012 [details] [diff] [review]
bb_cust_mh.diff

Review of attachment 785012 [details] [diff] [review]:
-----------------------------------------------------------------

<3 <3 <3

Thanks for the clean up!

::: misc.py
@@ +1860,5 @@
> +                        system_bits = mh_conf['system_bits']
> +                        conf_file = mh_conf['config_file']
> +
> +                        extra_args.extend(['--system-bits', system_bits])
> +                        extra_args.extend(['--cfg', conf_file])

Jason, could you please fold these 5 lines into the definition of extra args? e.g.:
  '--branch-name', opt_talos_branch,
  '--system-bits', platform_config['mozharness_config']['system_bits'],
  '--cfg', platform_config['mozharness_config']['config_file']
]

I think that system_bit should live inside of the mozharness configs; what do you think? Do you have time to tackle it if you agree with it?

	Jason Yeo[:jyeo] Assignee
	Comment 5 • 11 years ago

(In reply to Armen Zambrano G. [:armenzg] (Release Enginerring) (EDT/UTC-4) from comment #3)
> I think that system_bit should live inside of the mozharness configs; what
> do you think? Do you have time to tackle it if you agree with it?

Yep I think it's better to move more of the stuff out of buildbot but maybe we should future this?

	Armen [:armenzg] Reporter
	Comment 6 • 11 years ago

Comment on attachment 786913 [details] [diff] [review]
bb_cust_mh.diff

Review of attachment 786913 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. Good to land.

	Armen [:armenzg] Reporter
	Comment 7 • 11 years ago

Mind if I land it? I want to land a fix for bug 901715.

	Jason Yeo[:jyeo] Assignee
	Comment 9 • 11 years ago

I haven't tested it yet. I have no idea how to test the misc.py file. :-/

	Armen [:armenzg] Reporter
	Comment 10 • 11 years ago

Comment on attachment 787105 [details] [diff] [review]
bb_cust_mh.diff

http://hg.mozilla.org/build/buildbotcustom/rev/12f30d27abd6

	Armen [:armenzg] Reporter
	Comment 11 • 11 years ago

The patch will be live in our next reconfig.

(In reply to Jason Yeo [:jyeo] from comment #9)
> I haven't tested it yet. I have no idea how to test the misc.py file. :-/

I would user setup-master.py to setup a master that would use such a code (in this case any test master) and run a "buildbot checkconfig ."

	Nick Thomas [:nthomas] (UTC+12)
	Comment 12 • 11 years ago

In production.