Until bug 57441 and bug 66909 are resolved, it is necessary to alert the user about the need to restart after changing UI language or Region locale. Currently a message appears if these changes are made via the View menu, but no message appears if these changes are made via Prefs. Steps: 1) Go to Edit>Preferences and choose the Appearance panel (to change language) or the Content Packs panel under Appearance (to change region). 2) Select a different language or region, depending on the choice in Step 1. 3) Click OK. The Preferences window closes, but there is no message alerting the user to restart.

The explanatory paragraph at the top of the Content Packs panel UI ends with the statement "You must restart for a new content pack to take effect." We need to decide at least two things for how to handle this bug: 1) Is that sentence sufficient (will most users bother to read the paragraph)? 2) How long will it take to resolve bug 57441 and bug 66909?

->teruko to triage i18n/l10n prefs qa.

not sure who handles ui/tech writing for i18n/l10n items... cc'ing german and steve in case they might know who...

reassigning QA contact to jonrubin. German, can you take a look at the text? It's too late for this release, but we can fix this in the trunk if needed. No more UI changes on the branch though.

I think we need a restart message. I agree with Janathan, not many users will read the entire paragraph.

Msanz - If we get it ready on the branch, can this make a limbo build, or will it have to wait for the next release?

I dont think my team has the bandwidth to do the restart message for this release. Someone else will have to own that. thanks, Vishy

Msanz/Vishy - Can't we just repurpose the dialogue used for Themes?

This will have to wait for the next release. I don't see this is critical enough to justify a UI change. Please, do not implement the change in the branch. Trunk is fine.

Ccing Jatin. Jatin, if you're adding Help content for this still (this feature came in so late I don't know if there's time prior to our localization handoff), then a step for indicating a restart is necessary.

nav triage team: Marking nsbeta1+, p2, and mozilla1.0

In my original description, I said "Until bug 57441 and bug 66909 are resolved, it is necessary to alert the user about the need to restart after changing UI language or Region locale". I meant to say bug 62174 instead of bug 66909. 66909 addresses the need to restart in order to see a newly downloaded locale in the View menu.

Nominating for TM0.9.4. Vishy/Msanz - We need to identify the engineering team who is repsonsbile for fixing this one.

nav triage team: Marking mozilla0.9.4, nsbeta1+, and reassigning to ben

accepting.

Ben, could you be sure to test commercial also before checking this in. I'm not sure but this may need some similar code in the ns tree as well. Please speed this into the tree. thanks, Vishy

r=pchen

I've got Ben covered on commercial side. Just need an sr= and a=.

mass change, switching qa contact from jonrubin to ruixu.

Ben ~ Can or have we sent a message to drivers to see if we can get a sr= and a=? It looks like it has been waiting in the que for a bit.

Moving to 0.9.5 and marking as P3. No a stop ship per PDT

Mass-moving lower-priority 0.9.5 bugs off to 0.9.6 to make way for remaining 0.9.4/eMojo bugs, and MachV planning, performance and feature work. If you disagree with any of these targets, please let me know.

sr=hyatt

Comment on attachment 56455 [details] [diff] [review] updated patch that actually works >Index: prefwindow/resources/content/pref-appearance.xul >=================================================================== >RCS file: /cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-appearance.xul,v >retrieving revision 1.44 >diff -w -b -u -r1.44 pref-appearance.xul >--- pref-appearance.xul 2001/10/21 04:15:09 1.44 >+++ pref-appearance.xul 2001/11/04 03:21:39 >@@ -72,6 +71,17 @@ > return false; > } > } >+ >+ var promptService = Components.classes["@mozilla.org/embedcomp/prompt-service;1"].getService(Components.interfaces.nsIPromptService); >+ var strbundle = document.getElementById("navigatorBundle"); >+ var brandbundle = document.getElementById("brandBundle"); >+ >+ if (promptService) { No need for that if here, exceptions will be thrown :-) r=jag

Fix checked in.

.

It appears that pref-appearance.xul was busted by cvs conflicts being checked in with this patch.

Reopening to track bustage fix.

Checked in.

(ben will probably hate me, but ...) Reopening. This fix is wrong. 1) start browser, go the Edit->Preferences. Select Appearance panel 2) Change checkbox for "Show Tooltips". 3) Hit Ok to commit the change. Alert comes up "Preferred language changes will take effect when you restart." Huh? What does that have to do with tooltips. This is a completely confusing message for anyone. "Did I maybe change something I didn't mean to? Do I need to go back again and check?" Frankly, I think the explanatory text above the language menulist is all the information that a user requires; let's just back this out and mark it wontfix. (And alerts popping up from dialogs? Ewww.)

oops looks like I forgot to add a check for language changes. Sorry. As for alerts from dialogs, the text in the dialog reads "changes take effect when you restart mozilla" but i18n appears to want a dialog :-P

OK, I'm just going to back it out. There's no need for an annoying dialog when the dialog text specifies the restart.

Resolving.

Since bug 109477 (Content Packs description shouldn't say "you must restart") has been fixed, is it possible to change the description here to "You must restart browser for a new content pack to take effect." ? Leave as RESOLVED WONTFIX for now.