http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/locales/en-US/android_strings.dtd#182 Currently we show 'Automatic updates' on Beta and Release builds on Google Play but this preference serves no purpose. The update service is not used on these builds so why is the preference exposed on builds from Google Play?

We might be able to use the SysInfo.java flags to hide this setting for Beta and Release.

> Currently we show 'Automatic updates' on Beta and Release builds on Google Play but this preference serves no purpose. I don't see this preference anymore. All that's left now is to remove the button in about, correct?

Never mind, I missed it. Top of Advanced page.

This seems like the correct fix (until the updater service is fixed to not be enabled on release/beta). Just remove the preference in the release case.

I wonder if this is fixed now after bug 1220773 has landed. This should remove the setting if the app is installed (and therefore updated) from Google Play.

(In reply to Sebastian Kaspari (:sebastian) from comment #6) > I wonder if this is fixed now after bug 1220773 has landed. This should > remove the setting if the app is installed (and therefore updated) from > Google Play. Good question. But of course no way to know until 50 is in beta and installed from the google play store...

Comment on attachment 8775300 [details] [diff] [review] Potential fix Review of attachment 8775300 [details] [diff] [review]: ----------------------------------------------------------------- We could just let bug 1220773 ride the trains and close this one. However adding the additional check (see below) isn't going to hurt, so we could just land this too. However note that we have been thinking about offering an update mechanism for release versions on devices without google play (bug 1192279). For this we would have to revert this change again. However there's no movement on bug 1192279, so no real need to hold back because of that. Anyways, with the change below this is r+. ::: mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferenceFragment.java @@ +98,5 @@ > + > + if (AppConstants.RELEASE_BUILD || !UpdateServiceHelper.isUpdaterEnabled()) { > + ListPreference updates = (ListPreference) findPreference("app.update.autodownload"); > + if (updates != null) > + screen.removePreference(updates); We already remove the preference somewhere around line 710 (Look for AppConstants.MOZ_UPDATER). We could just add the RELEASE_BUILD check there.

I verified that with Aurora (50) installed from google play, we no longer show this option. I'm going to mark this WFM. Not worth it to take my patch.