Right now it looks like we pass --enable-updater in the release/beta mozconfigs, but then unset MOZ_UPDATER in the branding config. This is confusing. If we don't want the updater enabled we should not be passing --enable-updater. http://mxr.mozilla.org/mozilla-central/source/mobile/android/config/mozconfigs/android/release http://mxr.mozilla.org/mozilla-central/source/mobile/android/branding/official/configure.sh

I was looking at the update server and we see the requests like this https://aus4.mozilla.org/update/4/Fennec/36.0/20150126151813/Android_arm-eabi-gcc3/en-US/beta/4.1.2/default/default/36.0/update.xml which could come from the multi-locale or the en-US single-locale builds. There's about 90k per day for beta, if I'm reading newrelic right, which is much less than the Google Play numbers, but surprisingly high for people finding the single locale build by themselves (AFAIK we don't promote them anywhere). Ideally we'd disable the updater in the multi-locale build, or at least modify the locale to 'multi'. And in the newer single locale builds (bug 1019724) we'd have to leave the updater on.

This patch turns off the release button on the about page for release builds. My understanding is that RELEASE_BUILD is not set for Aurora or Nightly (based on this comment - https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#748

Comment on attachment 8775338 [details] [diff] [review] Turn off updater button for release builds Is this the right thing to do here?

FYI, RELEASE_BUILD was recently renamed to RELEASE_OR_BETA - https://groups.google.com/forum/#!topic/mozilla.dev.platform/fEWGkSsdMTU

Comment on attachment 8775338 [details] [diff] [review] Turn off updater button for release builds Review of attachment 8775338 [details] [diff] [review]: ----------------------------------------------------------------- This is definitely a working quick fix for this button but I wonder if we actually want to not set MOZ_UPDATER for release builds. I can't think of a reason why we want to do that (Maybe there's a historic reason? rnewman, nalexander or snorp might know). Is there a strong reason to land this quick fix? Note that we have been thinking about allowing release builds to be updated if they are not installed from Google Play (bug 1192279). No one is working on this currently though.

> Is there a strong reason to land this quick fix? Not really. I just figured that with the removal of the update item in settings, it would be nice to get rid of this as well in the same release.

(In reply to Mike Kaply [:mkaply] from comment #14) > Not really. I just figured that with the removal of the update item in > settings, it would be nice to get rid of this as well in the same release. The item will appear in settings if the app is installed from a different source (Controlled by ContextUtils.isInstalledFromGooglePlay()).

> The item will appear in settings if the app is installed from a different source (Controlled by ContextUtils.isInstalledFromGooglePlay()). Yes, but I don't believe we can use this same method to control this button, can we? Maybe that's the right solution here? I wonder why we couldn't just make these buttons hook up to the Google play updater...

(In reply to Mike Kaply [:mkaply] from comment #16) > I wonder why we couldn't just make these buttons hook up to the Google play > updater... Actually maybe we could just launch Google Play here when isInstalledFromGooglePlay() returns true: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/GeckoApp.java#719 Also see: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#4173

Are there any examples of launching Google Play in the code?

Should be as simple as starting an intent with URI "https://play.google.com/store/apps/details?id=org.mozilla.firefox" (or, better, the app package). I don't think we do so anywhere in the code already.

(In reply to Mike Kaply [:mkaply] from comment #18) > Are there any examples of launching Google Play in the code? Yeah, that's what I tried to link above - but the lines have moved. Here is a perma link: https://dxr.mozilla.org/mozilla-central/rev/b7f895c1dc2e91530240efbf50ac063a0f8a9cb5/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#4154-4158

According to bug 1357288, the update button no longer appears on 53 Release. It's also missing on my local build, but still present as usual on an official Nightly build. I don't see any obvious recent changes in the about page (https://hg.mozilla.org/mozilla-central/log/tip/mobile/android/chrome/content/about.xhtml) or the configure settings for MOZ_UPDATER (https://dxr.mozilla.org/mozilla-central/search?q=path%3Amobile*configure+MOZ_UPDATER&redirect=true), and the way I read the code, it shouldn't actually have ever been displayed in the first place, given that our Release branding configures unset MOZ_UPDATER. So does anybody have any idea why the #ifdef MOZ_UPDATER in about.xhtml (https://dxr.mozilla.org/mozilla-central/rev/a374c35469935a874fefe64d3e07003fc5bc8884/mobile/android/chrome/content/about.xhtml#32) didn't used to work and what changed in Firefox 53?

Do we want this to work or need it in 53? It sounds to me like we wanted the update button to be off (and, i think no update pings sent to balrog) for 52, but didn't fully turn that off, and now it's off for 53.

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195 Needinfo :susheel if you think this bug should be re-triaged.