Closed
Bug 903455
Opened 11 years ago
Closed 11 years ago
WebGL2 transform feedback - RASTERIZER_DISCARD
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: guillaume.abadie, Assigned: guillaume.abadie)
References
()
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
(deleted),
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
Implement the WebGL 2 feature EXT_transform_feedback
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #788254 -
Flags: review?(jgilbert)
Comment 2•11 years ago
|
||
Comment on attachment 788254 [details] [diff] [review]
patch revision 1
Review of attachment 788254 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/canvas/src/WebGLContext.h
@@ +762,5 @@
> + JS::Value GetParameter(JSContext* cx, WebGLenum pname, ErrorResult& rv);
> + bool IsEnabled(WebGLenum cap);
> +
> +private:
> + bool ValidateCapabilityEnum(WebGLenum cap, const char *info);
* to the left, since something else in this section does it.
Attachment #788254 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> Comment on attachment 788254 [details] [diff] [review]
> patch revision 1
>
> Review of attachment 788254 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: content/canvas/src/WebGLContext.h
> @@ +762,5 @@
> > + JS::Value GetParameter(JSContext* cx, WebGLenum pname, ErrorResult& rv);
> > + bool IsEnabled(WebGLenum cap);
> > +
> > +private:
> > + bool ValidateCapabilityEnum(WebGLenum cap, const char *info);
>
> * to the left, since something else in this section does it.
Fixed.
Thanks!
Assignee | ||
Comment 4•11 years ago
|
||
Target Milestone: --- → mozilla26
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Keywords: dev-doc-needed
Updated•9 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•