Closed
Bug 908232
Opened 11 years ago
Closed 11 years ago
WebGL2 RASTERIZER_DISCARD tracking
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: guillaume.abadie, Assigned: guillaume.abadie)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
Track RASTERIZER_DISCARD and generate warning if enabled and calling rasterizer related function.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #794114 -
Flags: review?(jgilbert)
|
|
Assignee | |
Comment 2•11 years ago
|
||
This patch also fix a bug when calling ForceClearFramebufferWithDefaultValues while RASTERIZER_DISCARD is enabled.
Attachment #794119 -
Flags: review?(jgilbert)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 794114 [details] [diff] [review]
patch step 1 - revision 1: state tracking refactor
Review of attachment 794114 [details] [diff] [review]:
-----------------------------------------------------------------
This is nice.
Attachment #794114 -
Flags: review?(jgilbert) → review+
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 794119 [details] [diff] [review]
patch step 2 - revision 2: Add RASTERIZER_DISCARD tracking
Review of attachment 794119 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/canvas/src/WebGLContextFramebufferOperations.cpp
@@ +24,5 @@
>
> if (mask == 0) {
> GenerateWarning("Calling gl.clear(0) has no effect.");
> + } else if (mRasterizerDiscardEnabled) {
> + GenerateWarning("Calling gl.clear() with RASTERIZER_DISCARD enabled has no effects.");
Nice!
Attachment #794119 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2aea1fd9522d
https://hg.mozilla.org/mozilla-central/rev/fba54a00792c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•