Closed
Bug 904922
Opened 11 years ago
Closed 11 years ago
[meta]WPS header is truncated across multiple locales
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(b2g18 affected)
VERIFIED
INVALID
Tracking | Status | |
---|---|---|
b2g18 | --- | affected |
People
(Reporter: delphine, Unassigned)
References
Details
(Keywords: l12y, Whiteboard: LocRun1.3, LocRun1.2)
Filed this bug to track other instances in v1.1, since it very often happens that the WPS header is truncated across multiple locales
We have asked localizers to find workarounds when possible for this, however this is not a long term solution
Reporter | ||
Comment 1•11 years ago
|
||
Happens in German, Croatian, Hungarian, Russian, Slovak, Serbian Cyrillic
Comment 2•11 years ago
|
||
The root cause here is that a string is shared across several UI elements. In this case it's the wpsMessage and it's being used for both button and header in https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/elements/wifi.html#L28 and https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/elements/wifi_wps.html#L9. In order to fix the issue in Slovak, we need to use two separate strings here, for example:
wpsMessage=Connect with WPS
wpsMessageButton=Connect with WPS
This way we are able to shorten the WPS header while keeping meaningful translation for the button.
Comment 3•11 years ago
|
||
This bug has been fixed on master (and will probably be on 1.3 soon) -- we now have two separate strings for all buttons/headers in Settings. See Bug 944749 .
I'm not sure if we should close this bug now or wait for the localizers to update their translations.
Comment 4•11 years ago
|
||
This issue also occurs with the Polish Language.
Blocks: 967050
Whiteboard: locrun1.3
Updated•11 years ago
|
Whiteboard: locrun1.3 → LocRun1.3, LocRun1.2
Comment 5•11 years ago
|
||
(In reply to Peter Bylenga from comment #4)
> This issue also occurs with the Polish Language.
As Théo said, with bug 944749 we have separate strings for button and headers in Settings.
If a locale still has this problem, I suggest to file a new bug in the localization component for that specific language. Since the button say "Connect with WPS", the next header can just say "Connect", or "WPS settings", etc.
Personally I would close this as fixed, but I'll let :delphine decide.
Flags: needinfo?(lebedel.delphine)
Reporter | ||
Comment 6•11 years ago
|
||
I agree with flod. Closing this bug as resolved-invalid for now.
Let's open up specific locale bugs if this continues in some languages
Feel free to reopen later if needed
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(lebedel.delphine)
Resolution: --- → INVALID
Reporter | ||
Comment 7•11 years ago
|
||
Please note: I've checked in all v1.3 supported locales and have found no truncations in this case anymore
Reporter | ||
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•