sync-1 Reporter
	Description • 11 years ago

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.184
 Firefox os  v1.1
 Mozilla build ID:20130806071254
 DEFECT DESCRIPTION:
  MMS notifications are not properly displayed.
  REPRODUCING PROCEDURES:
 Customer Impact Statement: 
  MMS notifications are not properly displayed, e.g. in case auto retrieve is set to off only "I have sent you a file. It will be available until dd.mm.yyyy" is shown. Apart from that the message not being translated, the message itself isn't really appropriate. An entry in the list for a received MMS notification shall contain the sender and the subject of the message and when it will expire as given in the received notifiaction.
 
  EXPECTED BEHAVIOUR:
 MMS notifications should properly displayed.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 high
  REPRODUCING RATE:
 5/5
  For FT PR, Please list reference mobile's behavior:

	Rick Waldron [:rwaldron]
	Comment 1 • 11 years ago

Can you include a screenshot and point to the relevant design docs for this? Thanks!!

	buri.blff
	Comment 2 • 11 years ago

I compare ff os with android, and I got the conclusion as follows:
1. FF os don't translate the string "I have sent you a file. It ..." in mms
when auto retrieve is off and language is set as German.
2. Both android and FF OS don't display any sender info when retrieve is off.
3. FF os have not a subject in MMS in leo build.

	buri.blff
	Comment 3 • 11 years ago

I will upload some screenshot soon. However, I think it's easy to reproduce. ^-^

	Julien Wajsberg [:julienw]
	Comment 4 • 11 years ago

> 1. FF os don't translate the string "I have sent you a file. It ..." in mms
when auto retrieve is off and language is set as German.

Do you mean it's never translated ? it really should be. Is it possible that you don't have the german translation for this ? Because in that case we fallback on english.

FYI we have an ongoing work in bug 886715 to review all uses of l10n and do it more properly.

for 2. and 3. I think it's currently implemented like it's specified, therefore I'm putting a needinfo flag for Ayman.

	田旻
	Comment 5 • 11 years ago

Hello, I have uploaded the screenshot, please check.

	田旻
	Comment 6 • 11 years ago

Please check.

	田旻
	Comment 7 • 11 years ago

(In reply to Rick Waldron from comment #1)
> Can you include a screenshot and point to the relevant design docs for this?
> Thanks!!

I have upload the screenshot and pics you need, please check.

	Joe Cheng [:jcheng] (please needinfo)
	Comment 8 • 11 years ago

An entry in the list for a received MMS notification shall contain the sender and the subject of the message and when it will expire as given in the received notifiaction.

Subject is not supported in v1.1.
Sender is shown in the title of the thread.

Can you confirm Subject is the request here?

	田旻
	Comment 9 • 11 years ago

(In reply to Joe Cheng [:jcheng] from comment #8)
> An entry in the list for a received MMS notification shall contain the
> sender and the subject of the message and when it will expire as given in
> the received notifiaction.
> 
> Subject is not supported in v1.1.
> Sender is shown in the title of the thread.
> 
> Can you confirm Subject is the request here?

I will ask my leader and give you feedback soon.

	田旻
	Comment 10 • 11 years ago

(In reply to Joe Cheng [:jcheng] from comment #8)
> An entry in the list for a received MMS notification shall contain the
> sender and the subject of the message and when it will expire as given in
> the received notifiaction.
> 
> Subject is not supported in v1.1.
> Sender is shown in the title of the thread.
> 
> Can you confirm Subject is the request here?

1. In my latest build, string like "I have sent you a file..." can be translated correctly in German.

2. But sender is not contained in the MMS notification as the description dose.
Can you add a sender in MMS notifation in this build?

3. Subject is not contained in the MMS notification either. I know this point, and I have told my leader about this. I am also waiting for his answer.

	Julien Wajsberg [:julienw]
	Comment 11 • 11 years ago

2. "MMS notification": do you mean the "message" that is displayed in the thread ?
Then the "sender" is shown at the top of the view, in the header. Isn't this enough ?

Note that if you want to change the message, it's probably too late for 1.1.

3. This is a new feature, we can try to do it for 1.2 (but we'll need update wireframes and visuals, so probably 1.3 is a safer goal), but we won't certainly do it for 1.1.

	田旻
	Comment 12 • 11 years ago

(In reply to 田旻 from comment #10)
> (In reply to Joe Cheng [:jcheng] from comment #8)
> > An entry in the list for a received MMS notification shall contain the
> > sender and the subject of the message and when it will expire as given in
> > the received notifiaction.
> > 
> > Subject is not supported in v1.1.
> > Sender is shown in the title of the thread.
> > 
> > Can you confirm Subject is the request here?
> 
> 1. In my latest build, string like "I have sent you a file..." can be
> translated correctly in German.
> 
> 2. But sender is not contained in the MMS notification as the description
> dose.
> Can you add a sender in MMS notifation in this build?
> 
> 3. Subject is not contained in the MMS notification either. I know this
> point, and I have told my leader about this. I am also waiting for his
> answer.

2. It's ok to postphone it on further version.
3. My leader suggest me to file a new bug about the display of sender.

	田旻
	Comment 13 • 11 years ago

I have filed a more detailed bug#908574 about this.

	Julien Wajsberg [:julienw]
	Comment 14 • 11 years ago

So now this bug is only about displaying the subject ?

nominating to koi instead of leo because of comment 12.

	ayman maat :maat
	Comment 15 • 11 years ago

(In reply to Julien Wajsberg [:julienw] from comment #4)
> > 1. FF os don't translate the string "I have sent you a file. It ..." in mms
> when auto retrieve is off and language is set as German.
> 
> Do you mean it's never translated ? it really should be. Is it possible that
> you don't have the german translation for this ? Because in that case we
> fallback on english.
> 
> FYI we have an ongoing work in bug 886715 to review all uses of l10n and do
> it more properly.
> 
> for 2. and 3. I think it's currently implemented like it's specified,
> therefore I'm putting a needinfo flag for Ayman.

point 2 and 3 in comment 2 are implemented as specified.

reference to point 2: This is also as specified. The sender of the MMS is detailed in the header of the message thread. As there is currently no 'group conversation' facility, and to the best of my knowledge wont be one for the foreseeable future, there is no need/requirement to include sender within the MMS thread... it just constitutes extra work to duplicate, and therefore present redundant information... I believe we have more pressing things to apply our resources to.

reference to point 3: the inclusion subject was not part of the requirements. In the Madrid ww we agreed to handle subject by concatenating it to the body text as a short term workaround... but for some reason that never happened. Subject will be formally addressed in V1.3 i believe.

	Julien Wajsberg [:julienw]
	Comment 16 • 11 years ago

(In reply to ayman maat :maat from comment #15)

> 
> reference to point 3: the inclusion subject was not part of the
> requirements. In the Madrid ww we agreed to handle subject by concatenating
> it to the body text as a short term workaround... but for some reason that
> never happened. Subject will be formally addressed in V1.3 i believe.

Maybe we can do that now for 1.2, if you tell us exactly what to do in those situations:

* with the notice because the mms is not autodownloaded
* in a mms whose content has been downloaded
  + if the first part is text
  + if the first part is a media
* in system notifications

	ayman maat :maat
	Comment 17 • 11 years ago

(In reply to Julien Wajsberg [:julienw] from comment #16)
> (In reply to ayman maat :maat from comment #15)
> 
> > 
> > reference to point 3: the inclusion subject was not part of the
> > requirements. In the Madrid ww we agreed to handle subject by concatenating
> > it to the body text as a short term workaround... but for some reason that
> > never happened. Subject will be formally addressed in V1.3 i believe.
> 
> Maybe we can do that now for 1.2, if you tell us exactly what to do in those
> situations:
> 
> * with the notice because the mms is not autodownloaded
> * in a mms whose content has been downloaded
>   + if the first part is text
>   + if the first part is a media
> * in system notifications

Sure, i will put some wireframs together.

...We also need to include the composition of a new MMS...how to include the subject in there. I saw some screens that Rick had knocked up for this, but it was not the path to follow from a UX PoV as it was not optimal and missed information that is required on the screen.

leaving ni for me as marker to produce the wireframes

	Julien Wajsberg [:julienw]
	Comment 18 • 11 years ago

I think we can split the composition in its own bug.

Thanks Ayman !

	Joe Cheng [:jcheng] (please needinfo)
	Comment 19 • 11 years ago

per comment 15, this bug seems invalid.

Adding subject we already have others bugs filed to track the work (but 885680: [MMS] Subject management in MMS)

	Julien Wajsberg [:julienw]
	Comment 20 • 11 years ago

it's a dupe then ;)

Removing Ayman's needinfo as he has already one on the duplicate bug.