Closed
Bug 905155
Opened 11 years ago
Closed 11 years ago
Remove the XPFE autocomplete component
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 26.0
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(2 files)
(deleted),
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
LDAP autocomplete was the last use of the XPFE autocomplete component.
Comment 1•11 years ago
|
||
Please don't blindly delete -- Graveyard is a better place.
Comment 2•11 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #1)
> Please don't blindly delete -- Graveyard is a better place.
err misread this as a bmo admin bug, not mailnews core. Ignore me
Assignee | ||
Comment 3•11 years ago
|
||
Seems that bug 789787 accidentally duplicated a block of code.
Assignee | ||
Comment 4•11 years ago
|
||
This just leaves the jar.mn and resources.
Attachment #790208 -
Flags: review?(mbanner)
Comment 5•11 years ago
|
||
Comment on attachment 790206 [details] [diff] [review]
Stop linking XPFE autocomplete into libxul
Yay!
Attachment #790206 -
Flags: review?(mbanner) → review+
Updated•11 years ago
|
Attachment #790208 -
Flags: review?(mbanner) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
Comment 8•11 years ago
|
||
Not sure this is related, but starting a compose window prints ### ERROR - unable to create search "ldap". which is here http://mxr.mozilla.org/comm-central/source/mozilla/xpfe/components/autocomplete/resources/content/autocomplete.xml#254
... so i suppose we're still using the xpfe autocomplete. Do we just need to remove the AUTOCOMPLETE_OLD_STYLE defines here? http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/xul.css#749
(I don't get the error with local non-packaged builds so i though it's easer to ask.)
Assignee | ||
Comment 9•11 years ago
|
||
(In reply to Magnus Melin from comment #8)
> (I don't get the error with local non-packaged builds
Probably because we're not packaging the component. Oops.
Comment 10•7 years ago
|
||
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/9dfd51ec3a5b
Stop building the XPFE autocomplete component r=Standard8
You need to log in
before you can comment on or make changes to this bug.
Description
•