Closed
Bug 908135
Opened 11 years ago
Closed 11 years ago
B2G NetworkManager: Remove dhcp attribute in nsINetworkInterface
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
In nsINetworkInterface, there is a |dhcp| attribute [1], it is used for asking NetworkManager to help to send dhcp request when a interface is registered. But in current code base, no matter ril or wifi, |dhcp| is always set to false. And actually getting IP things should be handled in each interface, instead of in NetworkManager. So we should remove this attribute and related codes.
[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/nsINetworkManager.idl#42
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 793957 [details] [diff] [review]
Remove dhcp attribute in nsINetworkInterface, v1
I have tested this patch in unagi device, the below are test cases:
1. Mobile data connectivity
2. Wifi connectivity
3. Mobile data + usb tethering
4. Mobile data + wifi hotspot
Vicamo, Vincent, could you help to review this patch? Thanks
Attachment #793957 -
Flags: review?(vyang)
Attachment #793957 -
Flags: review?(vchang)
Updated•11 years ago
|
Attachment #793957 -
Flags: review?(vyang) → review+
Updated•11 years ago
|
Attachment #793957 -
Flags: review?(vchang) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #793957 -
Attachment is obsolete: true
Assignee | ||
Comment 6•11 years ago
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•