Edgar Chen [:edgar] Reporter
	Description • 11 years ago

To let NetworkManager can control each network, we should have connect()/disconnect() in nsINetworkInterface. And we also put all information which is needed by other module into nsINetworkInfo. So that we could just expose nsINetworkInfo instead of whole nsINetworkInterface, because we should not expose connect() and disconnect() outside NetworkManager.

The redefined nsINetworkInterface as below:

interface nsINetworkInterface {
  readonly attribute nsINetworkInfoinfo;
  readonly attribute nsIDOMString[] hostRoutes;
  readonly attribute DOMString httpProxyHost;
  readonly attribute long httpProxyPort;
  void connect();
  void disconnect();

  attribute nsIDOMEventListener onnetworkinfochanged;
}

interface nsINetworkInfo {
  readonly attribute long type; /* WIFI/MOBILE/MMS/SUPL */
  readonly attribute long serviceId; /* Mulit-SIM */
  readonly attribute long state;
  readonly attribute DOMString name; /* Interface name */
  readonly attribute DOMString ip;
  readonly attribute DOMString netmask;
  readonly attribute DOMString broadcast;
  readonly attribute DOMString gateway;
  readonly attribute DOMString dns1;
  readonly attribute DOMString dns2;
}

	Edgar Chen [:edgar] Reporter
	Comment 1 • 11 years ago

(In reply to Edgar Chen [:edgar][:echen] from comment #0)
> 
> interface nsINetworkInfo {
>   readonly attribute long type; /* WIFI/MOBILE/MMS/SUPL */
Maybe we could consider use DOMString for type. In this way, we could get some advantage as below:
1. For the network interface of RIL, we can use the type in apn setting directly. So that we don't need to have a mapping between apn type and the const, NETWORK_TYPE_*.
2. If a new network is added, we don't have to add a new const for it.

>   readonly attribute long serviceId; /* Mulit-SIM */
>   readonly attribute long state;
>   readonly attribute DOMString name; /* Interface name */
>   readonly attribute DOMString ip;
>   readonly attribute DOMString netmask;
>   readonly attribute DOMString broadcast;
>   readonly attribute DOMString gateway;
>   readonly attribute DOMString dns1;
>   readonly attribute DOMString dns2;
> }

	Edgar Chen [:edgar] Reporter
	Comment 2 • 11 years ago

About the comment #1, I will file a new bug for that, for now we still use long for network type.

	Edgar Chen [:edgar] Reporter
	Comment 11 • 11 years ago

Comment on attachment 797020 [details] [diff] [review]
WIP, Part1: Interface changes, v3

Vincent, Vicamo, could you help to give me some feedback about the new nsINetworkInterface? Thanks.

	Vincent Chang[:vchang][changyihsin]
	Comment 12 • 11 years ago

Comment on attachment 797020 [details] [diff] [review]
WIP, Part1: Interface changes, v3

Review of attachment 797020 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/nsINetworkInterface.idl
@@ +112,5 @@
> +
> +  /**
> +   * This event is fired when the info of network interface is changed.
> +   */
> +  attribute nsIDOMEventListener onnetworkinfochanged;

Wifi supports http proxy for different ssid. So the proxy server ip and port may change when connect to different AP. Do we want to pass updated parameters when connection status change ?

	Edgar Chen [:edgar] Reporter
	Comment 13 • 11 years ago

Comment on attachment 797020 [details] [diff] [review]
WIP, Part1: Interface changes, v3

Because we still have a lot of things under discussion, so cancel the feedback request first.

	Ken Chang[:kenkai]
	Comment 14 • 11 years ago

Put this bug into backlog.

	Anshul
	Comment 15 • 10 years ago

Hey Wesley, is this bug intended for 2.1?

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 16 • 10 years ago

(In reply to Anshul from comment #15)
> Hey Wesley, is this bug intended for 2.1?

Hey Anshul, no, it's not.

	Kai-Chih Hu [:khu]
	Comment 17 • 10 years ago

Use feature-b2g:3.0? rather than 2.3?.

	Jessica Jong [:jessica] (inactive)
	Comment 18 • 9 years ago

Per offline discussion with Edgar, we decided to mark this bug as a meta bug, and file sub-bugs to:
- put all information needed by other modules into a separate interface - nsINetworkInfo
- Add activate()/deactivate in nsINetworkInterface and RIL implementation (probably bug 911713)
- Implement nsINetworkInterface.active()/deactive in wifi network interface
and other bugs that may come to mind later...

	BMO Automation
	Comment 19 • 7 years ago

Firefox OS is not being worked on