Closed Bug 908226 Opened 11 years ago Closed 11 years ago

Install moztest in desktop and b2g unittest scripts

Categories

(Release Engineering :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: chmanchester, Assigned: ahal)

References

Details

(Whiteboard: [mozharness])

Attachments

(1 file, 1 obsolete file)

This looks like the way to do it.
Attachment #794060 - Flags: review?(ahalberstadt)
Assignee: nobody → cmanchester
Unfortunately this depends on bug 907895 landing on every single branch :(

We should probably get these lists from the in-tree config to avoid situations like this in the future.
Status: NEW → ASSIGNED
Component: General → General Automation
Depends on: 907895
Product: Testing → Release Engineering
QA Contact: catlee
Whiteboard: [mozharness]
Comment on attachment 794060 [details] [diff] [review]
Install moztest in desktop and b2g mozharness scripts;

Review of attachment 794060 [details] [diff] [review]:
-----------------------------------------------------------------

This is good, but we'll need to wait on the dependency, so we can't land it yet.
Attachment #794060 - Flags: review?(ahalberstadt) → review+
The previous patch can't land because the moztest fix couldn't be easily landed on the release branch. Instead we should emulate the solution used for the marionette script in bug 908356.

Ash run going here:
https://tbpl.mozilla.org/?tree=Ash&rev=31d60358dfc7
Assignee: chmanchester → ahalberstadt
Attachment #794060 - Attachment is obsolete: true
Attachment #804665 - Flags: review?(jgriffin)
Comment on attachment 804665 [details] [diff] [review]
Patch 1.0 - use in tree requirements for desktop and b2g unittests

Review of attachment 804665 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/desktop_unittest.py
@@ +195,5 @@
> +            self.register_virtualenv_module(m, url=os.path.join(mozbase_dir,
> +                m))
> +
> +        self.register_virtualenv_module('marionette', url=os.path.join('tests',
> +            'marionette'))

We don't use Marionette in desktop unit tests at all.
Attachment #804665 - Flags: review?(jgriffin) → review+
I've removed the marionette line in my local patch. Missed an import though, new ash run:
https://tbpl.mozilla.org/?tree=Ash&rev=cfb9ed59d9da
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: